fix(rollup): fallback HTTP polling without filtering #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
added
C-enhancement
merklefruit
changed the base branch from
main
to
nico/feat/init-pipeline-fix
merklefruit
changed the title
refcell
approved these changes
Sep 9, 2024
Comment on lines
+94
to
+101
| if err | ||
| .as_error_resp() | ||
| .is_some_and(|resp| !resp.message.to_lowercase().contains("not supported")) | ||
| { | ||
| // On any error other than "not supported", return the error and fail. | ||
| error!("Failed to watch new blocks via HTTP"); | ||
| return Err(err); | ||
| } |
There was a problem hiding this comment.
I think this is fine, but we should also then allow the user to pass an --http flag that uses http polling explicitly instead of subscriptions in order to not get caught in this block.
There was a problem hiding this comment.
I don't fully get what the flag would mean, could you elaborate?
If the URL scheme is HTTP we are forced to poll
merklefruit
added a commit
that referenced
this pull request
Sep 11, 2024
This PR introduces a new wrapper struct: `ExExHeraContext`. This struct wraps `ExExContext` with a copy of `InMemoryChainProvider`, such that every newly committed chain gets automatically injected into the same L1 provider cache that's used by the rollup pipeline when running as ExEx. This abstraction allows us to stop worrying about caching L1 blocks (which was previously marked as TODO in the derivation loop) and also makes full use of the data inside `Arc<Chain>`, such as receipts. ### Stack - main - #88 - #89 - 👉 #91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a second method of polling via HTTP that doesn't rely on the
eth_filterfeature.This will be auto-detected and triggered as fallback. It's mostly useful for test purposes.
eth_newBlockFilterandeth_getFilterChanges#87Stack