Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: porto offline tx support #28

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

feat: porto offline tx support #28

wants to merge 23 commits into from

Conversation

o-az
Copy link
Collaborator

@o-az o-az commented Jan 21, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a111aa4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oddworld ❌ Failed (Inspect) Jan 31, 2025 1:41am
oddworld-playground 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:41am
porto-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:41am
porto-wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:41am

@gakonst
Copy link

gakonst commented Jan 23, 2025

Spend permissions is integrated, would be great to incorporate it in our example eg a server that's delegated to call a certain function that moves 100 USDC per day

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2025

@o-az is attempting to deploy a commit to the Ithaca Team on Vercel.

A member of the Team first needs to authorize it.

jenpaff
jenpaff reviewed Jan 28, 2025
View reviewed changes
examples/offline/server/env.d.ts Outdated
@@ -0,0 +1,18 @@
// cloudflare workers types
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be a cloudflare worker type?

jenpaff
jenpaff reviewed Jan 28, 2025
View reviewed changes
examples/offline/app/src/App.tsx Outdated
<select name="action">
<option value="mint">Mint 100 EXP</option>
<option value="approve-transfer">Approve + Transfer 50 EXP</option>
<option value="noop">Noop Calls</option>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

jenpaff
jenpaff reviewed Jan 28, 2025
View reviewed changes
examples/offline/app/index.html Outdated
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" href="https://ithaca.xyz/icon.png" type="image/png" sizes="310x270">
<title>Offline Transaction</title>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the term Offline Transaction slightly confusing- what exactly does it mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenpaff jenpaff jenpaff left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@o-az @gakonst @jenpaff