feat(global): change onBackground to isOnBackground

ithaka · Oct 25, 2023 · 23bbd23 · 23bbd23
1 parent c704a74
commit 23bbd23
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/packages/pharos/src/components/dropdown-menu/PharosDropdownMenu.react.stories.jsx b/packages/pharos/src/components/dropdown-menu/PharosDropdownMenu.react.stories.jsx
@@ -178,7 +178,7 @@ export const FullWidth = {
   ),
 };
 
-export const OnBackground = {
+export const isOnBackground = {
   render: () => (
     <div
       style={{
@@ -195,7 +195,7 @@ export const OnBackground = {
       >
         A menu on background
       </PharosButton>
-      <PharosDropdownMenu id="my-menu-on-background" show-selected on-background>
+      <PharosDropdownMenu id="my-menu-on-background" show-selected is-on-background>
         <PharosDropdownMenuItem selected>Item One</PharosDropdownMenuItem>
         <PharosDropdownMenuItem>Item Two</PharosDropdownMenuItem>
         <PharosDropdownMenuItem disabled>Item Three</PharosDropdownMenuItem>

diff --git a/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu-item.ts b/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu-item.ts
@@ -76,7 +76,7 @@ export class PharosDropdownMenuItem extends ScopedRegistryMixin(FocusMixin(Pharo
    * @attr is-on-background
    */
   @property({ type: Boolean, reflect: true, attribute: 'is-on-background' })
-  public onBackground = false;
+  public isOnBackground = false;
 
   @state()
   private _first = false;

diff --git a/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.ts b/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.ts
@@ -57,7 +57,7 @@ export class PharosDropdownMenu extends ScopedRegistryMixin(FocusMixin(OverlayEl
    * @attr is-on-background
    */
   @property({ type: Boolean, reflect: true, attribute: 'is-on-background' })
-  public onBackground = false;
+  public isOnBackground = false;
 
   @state()
   private _navMenu = false;
@@ -268,9 +268,9 @@ export class PharosDropdownMenu extends ScopedRegistryMixin(FocusMixin(OverlayEl
               top: `${y}px`,
             });
           });
-          if (this.onBackground) {
+          if (this.isOnBackground) {
             this._allMenuItems.forEach((menuItem) => {
-              menuItem.onBackground = true;
+              menuItem.isOnBackground = true;
             });
           }
         }

diff --git a/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.wc.stories.jsx b/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.wc.stories.jsx
@@ -178,7 +178,7 @@ export const FullWidth = {
   },
 };
 
-export const OnBackground = {
+export const isOnBackground = {
   render: () => {
     const effect = () => {
       useEffect(() => {
@@ -197,7 +197,7 @@ export const OnBackground = {
         >
           A menu on background
         </storybook-pharos-button>
-        <storybook-pharos-dropdown-menu id="my-menu-on-background" show-selected on-background>
+        <storybook-pharos-dropdown-menu id="my-menu-on-background" show-selected is-on-background>
           <storybook-pharos-dropdown-menu-item selected>
             Item One
           </storybook-pharos-dropdown-menu-item>

diff --git a/packages/pharos/src/components/dropdown-menu/storyArgs.ts b/packages/pharos/src/components/dropdown-menu/storyArgs.ts
@@ -2,5 +2,5 @@ export const defaultArgs = {
   open: false,
   showSelected: false,
   fullWidth: false,
-  onBackground: false,
+  isOnBackground: false,
 };