Merge branch 'develop' into feat/rotation-icon

ithaka · Jan 24, 2025 · 972f088 · 972f088
2 parents f563cd3 + ecff778
commit 972f088
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/silver-suits-wait.md b/.changeset/silver-suits-wait.md
@@ -0,0 +1,5 @@
+---
+'@ithaka/pharos': patch
+---
+
+Update the close button in sidenav
diff --git a/packages/pharos/src/components/sidenav/pharos-sidenav.scss b/packages/pharos/src/components/sidenav/pharos-sidenav.scss
@@ -51,7 +51,7 @@
   opacity: 0;
   position: absolute;
   top: var(--pharos-spacing-one-quarter-x);
-  left: var(--pharos-spacing-one-quarter-x);
+  right: var(--pharos-spacing-one-quarter-x);
 }
 
 :host([has-close-button]) {

diff --git a/packages/pharos/src/components/sidenav/pharos-sidenav.ts b/packages/pharos/src/components/sidenav/pharos-sidenav.ts
@@ -133,7 +133,7 @@ export class PharosSidenav extends ScopedRegistryMixin(FocusMixin(SideElement))
     return this.hasCloseButton
       ? html`<pharos-button
           class="side-element__button"
-          icon="close"
+          icon="chevron-left"
           variant="subtle"
           a11y-label="Close menu"
           is-on-background