Skip to content

Commit

Permalink
Update dependencies (#837)
Browse files Browse the repository at this point in the history
* chore: update to yarn 4.5.3

* chore: bump all minor and patch versions of dependencies

There is one exception: @lit-labs/scoped-registry-mixin. Updating it is
breaking our unit tests with an odd type error, so punting on that update
for now.

* chore: remove deprecated husky configuration

* chore: update dependencies

* fix(combobox): dropdown button a11y label location

Because the label is on the icon inside a button, when
webkit renders it, it is failing our axe a111y tests.

* chore: refresh yarn lock

* chore: add changeset
  • Loading branch information
brentswisher authored Dec 6, 2024
1 parent 91870ce commit 9a5672b
Show file tree
Hide file tree
Showing 11 changed files with 2,928 additions and 2,811 deletions.
5 changes: 5 additions & 0 deletions .changeset/dry-plums-trade.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Update the combobox component to set the accessible title on the button, not the icon itself
3 changes: 0 additions & 3 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn commitlint --edit "$1"
3 changes: 0 additions & 3 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn pretty-quick --staged
yarn lint-staged
614 changes: 307 additions & 307 deletions .yarn/releases/yarn-4.5.1.cjs → .yarn/releases/yarn-4.5.3.cjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-4.5.1.cjs
yarnPath: .yarn/releases/yarn-4.5.3.cjs
61 changes: 32 additions & 29 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,57 +61,57 @@
"@babel/plugin-syntax-import-assertions": "^7.26.0",
"@babel/preset-env": "^7.26.0",
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.9",
"@commitlint/cli": "^19.5.0",
"@commitlint/config-conventional": "^19.5.0",
"@emotion/babel-plugin": "^11.12.0",
"@changesets/cli": "^2.27.10",
"@commitlint/cli": "^19.6.0",
"@commitlint/config-conventional": "^19.6.0",
"@emotion/babel-plugin": "^11.13.5",
"@size-limit/preset-small-lib": "^11.1.6",
"@storybook/addon-a11y": "^8.4.2",
"@storybook/addon-essentials": "^8.4.2",
"@storybook/addon-links": "^8.4.2",
"@storybook/blocks": "^8.4.2",
"@storybook/manager-api": "^8.4.2",
"@storybook/react-vite": "^8.4.2",
"@storybook/theming": "^8.4.2",
"@storybook/web-components": "^8.4.2",
"@storybook/web-components-vite": "^8.4.2",
"@storybook/addon-a11y": "^8.4.7",
"@storybook/addon-essentials": "^8.4.7",
"@storybook/addon-links": "^8.4.7",
"@storybook/blocks": "^8.4.7",
"@storybook/manager-api": "^8.4.7",
"@storybook/react-vite": "^8.4.7",
"@storybook/theming": "^8.4.7",
"@storybook/web-components": "^8.4.7",
"@storybook/web-components-vite": "^8.4.7",
"@types/uuid": "^10.0.0",
"@typescript-eslint/eslint-plugin": "^8.14.0",
"@typescript-eslint/parser": "^8.14.0",
"@vitejs/plugin-react": "^4.3.3",
"@typescript-eslint/eslint-plugin": "^8.17.0",
"@typescript-eslint/parser": "^8.17.0",
"@vitejs/plugin-react": "^4.3.4",
"all-contributors-cli": "^6.26.1",
"concurrently": "^9.1.0",
"cssnano": "^7.0.6",
"eslint": "^9.14.0",
"eslint": "^9.16.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-jsx-a11y": "^6.10.2",
"eslint-plugin-lit": "^1.15.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-react": "^7.37.2",
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-storybook": "^0.11.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-storybook": "^0.11.1",
"eslint-plugin-wc": "^2.2.0",
"globals": "^15.12.0",
"husky": "^9.1.6",
"globals": "^15.13.0",
"husky": "^9.1.7",
"lint-staged": "^15.2.10",
"lit": "^2.8.0",
"lit-analyzer": "^2.0.3",
"markdown-toc": "^1.2.0",
"postcss": "^8.4.49",
"postcss-import": "^16.1.0",
"postcss-media-minmax": "^5.0.0",
"postcss-preset-env": "^10.1.0",
"prettier": "^3.3.3",
"postcss-preset-env": "^10.1.1",
"prettier": "^3.4.2",
"pretty-quick": "^4.0.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"sass": "^1.80.6",
"sass": "^1.82.0",
"size-limit": "^11.1.6",
"storybook": "^8.4.2",
"stylelint": "^16.10.0",
"storybook": "^8.4.7",
"stylelint": "^16.11.0",
"stylelint-config-standard-scss": "^13.1.0",
"stylelint-scss": "^6.9.0",
"svglint": "^3.0.0",
"stylelint-scss": "^6.10.0",
"svglint": "^3.1.0",
"vite": "^5.4.11"
},
"workspaces": {
Expand All @@ -124,5 +124,8 @@
"path": "packages/pharos/lib/index.js"
}
],
"packageManager": "[email protected]"
"resolutions": {
"@lit-labs/scoped-registry-mixin": "1.0.1"
},
"packageManager": "[email protected]"
}
4 changes: 2 additions & 2 deletions packages/pharos-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
},
"devDependencies": {
"@types/jest": "^29.5.14",
"@types/node": "^22.9.0",
"@types/node": "^22.10.1",
"jest": "^29.7.0",
"ts-jest": "^29.2.5",
"ts-morph": "^24.0.0",
"ts-node": "^10.9.2",
"typescript": "^5.6.3"
"typescript": "^5.7.2"
},
"scripts": {
"test": "jest",
Expand Down
10 changes: 5 additions & 5 deletions packages/pharos-site/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,22 @@
"gatsby-plugin-sharp": "^5.14.0",
"gatsby-source-filesystem": "^5.14.0",
"gatsby-transformer-sharp": "^5.14.0",
"prettier": "^3.3.3",
"prettier": "^3.4.2",
"prism-react-renderer": "^2.4.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-helmet": "^6.1.0",
"sass": "^1.80.6"
"sass": "^1.82.0"
},
"devDependencies": {
"@babel/plugin-proposal-object-rest-spread": "^7.20.7",
"@babel/plugin-transform-private-methods": "^7.25.9",
"@types/reach__router": "^1.3.15",
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/react": "^18.3.14",
"@types/react-dom": "^18.3.2",
"@types/react-helmet": "^6.1.11",
"babel-preset-gatsby": "^3.14.0",
"typescript": "^5.6.3"
"typescript": "^5.7.2"
},
"author": "ITHAKA",
"license": "MIT",
Expand Down
10 changes: 5 additions & 5 deletions packages/pharos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@
"devDependencies": {
"@custom-elements-manifest/analyzer": "^0.10.3",
"@open-wc/testing": "^4.0.0",
"@types/mocha": "^10.0.9",
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/mocha": "^10.0.10",
"@types/react": "^18.3.14",
"@types/react-dom": "^18.3.2",
"@web/test-runner": "^0.19.0",
"@web/test-runner-commands": "^0.9.0",
"@web/test-runner-playwright": "^0.11.0",
Expand All @@ -79,7 +79,7 @@
"globby": "^14.0.2",
"minify-html-literals": "^1.3.5",
"postcss": "^8.4.49",
"prettier": "^3.3.3",
"prettier": "^3.4.2",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"replace-in-file": "^8.2.0",
Expand All @@ -88,7 +88,7 @@
"sinon": "^19.0.2",
"style-dictionary": "^3.9.2",
"ts-lit-plugin": "^2.0.2",
"typescript": "^5.6.3"
"typescript": "^5.7.2"
},
"customElements": "custom-elements.json",
"exports": {
Expand Down
7 changes: 2 additions & 5 deletions packages/pharos/src/components/combobox/pharos-combobox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -289,15 +289,12 @@ export class PharosCombobox extends ScopedRegistryMixin(FormMixin(FormElement))
tabindex="-1"
type="button"
class="combobox__button"
aria-label="Dropdown"
?disabled=${this.disabled}
@click=${this._handleButtonClick}
@blur=${this._handleButtonBlur}
>
<pharos-icon
class="combobox__icon"
name="chevron-down"
a11y-title="Dropdown"
></pharos-icon>
<pharos-icon class="combobox__icon" name="chevron-down" a11y-hidden="true"></pharos-icon>
</button>
`;
}
Expand Down
Loading

0 comments on commit 9a5672b

Please sign in to comment.