Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidenav component documentation and function on pharos-site #653

Closed
shoupeva-ithaka opened this issue Nov 29, 2023 · 1 comment
Closed

Fix sidenav component documentation and function on pharos-site #653

shoupeva-ithaka opened this issue Nov 29, 2023 · 1 comment
Assignees
@satya-achanta-venkata
Labels
bug component/sidenav ithaka/pharos-site
Milestone
@ithaka/pharos v1...

Comments

@shoupeva-ithaka
Copy link
Contributor

Description
With the PharosSidenavButton being removed in v14.0.0, the Pharos site navigation will no longer function the same. The sidenav will no longer collapse on mobile. The sidenav documentation will be out of date and the code example will no longer be relevent.
@satya-achanta-venkata
Copy link
Contributor

@shoupeva-ithaka I see Chris Brown removed all the code that is related to PharosSidenavButton here, so this issue can be closed.

@daneah daneah mentioned this issue Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satya-achanta-venkata satya-achanta-venkata

Labels
bug component/sidenav ithaka/pharos-site
Projects
None yet
Milestone
@ithaka/pharos v14.0.0
Development

When branches are created from issues, their pull requests are automatically linked.

fix/pharos-site-sidenav ithaka/pharos
3 participants
@daneah @satya-achanta-venkata @shoupeva-ithaka