Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elevation tokens and documentation #643

Merged
merged 17 commits into from
Nov 29, 2023
Merged

Add elevation tokens and documentation #643

merged 17 commits into from
Nov 29, 2023

Conversation

nkamau
Copy link
Contributor

@nkamau nkamau commented Oct 25, 2023

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?

Resolves #641

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: ebc80fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

size-limit report 📦

Path Size
packages/pharos/lib/index.js 52.78 KB (-0.01% 🔽)

@nkamau nkamau changed the title Docs/elevation Elevation.mdx Oct 27, 2023
@nkamau nkamau changed the title Elevation.mdx elevation.mdx Oct 27, 2023
@shoupeva-ithaka shoupeva-ithaka marked this pull request as ready for review November 7, 2023 20:10
@shoupeva-ithaka shoupeva-ithaka requested a review from a team as a code owner November 7, 2023 20:10
@shoupeva-ithaka shoupeva-ithaka requested review from mtorres3, satya-achanta-venkata and shoupeva-ithaka and removed request for a team November 7, 2023 20:10
shoupeva-ithaka and others added 2 commits November 7, 2023 15:10
Adds a new storybook page for the new elevation tokens in both
react and web component flavors.
@daneah daneah changed the title elevation.mdx Add elevation tokens and documentation Nov 7, 2023
install_nvm.sh Outdated Show resolved Hide resolved
packages/pharos/tokens/elevation.json Outdated Show resolved Hide resolved
@daneah daneah merged commit 9cf3860 into develop Nov 29, 2023
6 checks passed
@daneah daneah deleted the docs/elevation branch November 29, 2023 22:25
sirrah-tam pushed a commit to sirrah-tam/pharos that referenced this pull request Dec 1, 2023
* docs(elevation): starter elevation documentation

* Empty-Commit

* Empty-Commit

* docs(elevation): fix build errors

* feat(elevation): add elevation tokens and pharos site pages

* docs(elevation): add storybook stories

Adds a new storybook page for the new elevation tokens in both
react and web component flavors.

* docs(elevation): remove accidentally included file

* docs(elevation): added tokens to brand expressions page

* docs: elevation update

* docs(site): add elevation link to tokens sidenav section

* docs: elevation final update

* docs: elevation final update

* chore: add changeset

---------

Co-authored-by: Njoki Kamau <[email protected]>
Co-authored-by: Njoki Kamau <[email protected]>
Co-authored-by: Markell Torres <[email protected]>
Co-authored-by: Markell Torres <[email protected]>
Co-authored-by: Evan Shoup <[email protected]>
Co-authored-by: Brent Swisher <[email protected]>
Co-authored-by: Dane Hillard <[email protected]>
daneah added a commit that referenced this pull request Dec 19, 2023
* develop:
  A11y revamp: Pharos buttons (non-breaking change) (#628)
  Radio, Checkbox: Fix group label (#652)
  Add elevation tokens and documentation (#643)
  fix(sidenav-link): external link opens in new tab (#645)
  Upgrade to TypeScript 5 (#644)
  feat(cli): add newly created components created using pharos-cli to initComponents files (#630)
  chore: version packages (#640)
  Coach Mark: Fix react component positioning (#638)
  Coach Mark: Documentation fixes (#639)
  chore(deps): bump @babel/traverse from 7.20.0 to 7.23.2 (#637)
  chore: version packages (#636)
  Icon: Add Panorama icon (#631)
  chore: version packages (#629)
  Loading spinner: add small and on background variant (#627)
  chore: version packages (#626)
  Sheet: allow expansion with attribute (#625)
  fix(button): remove fill on subtle disabled button on background (#618)
  chore(deps-dev): bump postcss from 8.4.25 to 8.4.31 (#624)
  chore: version packages (#623)
  Sheet: Add more close options and transition timing function (#620)
@github-actions github-actions bot mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Elevation to Pharos site "Design Tokens" and Storybook
5 participants