-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to latest compatible versions #716
Conversation
|
size-limit report 📦
|
…t-renderer
When I did the updates in #716, I had to pin this package to `0.9.0` to keep things working without looking too deeply into the reason. After that got merged and with some fresh cognitive capacity, I looked into this and ultimately filed open-wc/custom-elements-manifest#242, where the team was kind enough to guide me through what changed and what the expectations are going forward for this format. This change stops relying on the presence of `resolveInitializer`, which is a leaky abstraction, and instead checks if there are any matching variable values directly. I verified the output is identical, save for the ordering of the exports in the built `packages/pharos/src/react-components/index.ts` file, which is definitely acceptable; I think they're even in alphabetical order, now.
When I did the updates in #716, I had to pin this package to `0.9.0` to keep things working without looking too deeply into the reason. After that got merged and with some fresh cognitive capacity, I looked into this and ultimately filed open-wc/custom-elements-manifest#242, where the team was kind enough to guide me through what changed and what the expectations are going forward for this format. This change stops relying on the presence of `resolveInitializer`, which is a leaky abstraction, and instead checks if there are any matching variable values directly. I verified the output is identical, save for the ordering of the exports in the built `packages/pharos/src/react-components/index.ts` file, which is definitely acceptable; I think they're even in alphabetical order, now.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Fixes #708
Bump as many dependencies as we can without incurring a bunch of work. Remaining dependencies require resolving known or new compatibility issues, for things like:
How does this change work?
Use
yarn upgrade-interactive
repeatedly and run things likeyarn test
,yarn lint
,yarn site:develop
,yarn storybook:wc:dev
in between to see if anything's broken.Additional context
Before
After