Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest compatible versions #716

Merged
merged 28 commits into from
Mar 13, 2024

Conversation

daneah
Copy link
Member

@daneah daneah commented Mar 12, 2024

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?

Fixes #708

Bump as many dependencies as we can without incurring a bunch of work. Remaining dependencies require resolving known or new compatibility issues, for things like:

How does this change work?

Use yarn upgrade-interactive repeatedly and run things like yarn test, yarn lint, yarn site:develop, yarn storybook:wc:dev in between to see if anything's broken.

Additional context

Before
Screenshot 2024-03-12 at 21 41 34

After
Screenshot 2024-03-12 at 21 40 05

Sorry, something went wrong.

@daneah daneah added status/code review dependencies Pull requests that update a dependency file labels Mar 12, 2024
Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 988d824

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 12, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 62.93 KB (+15.42% 🔺)

@daneah daneah marked this pull request as ready for review March 13, 2024 01:46
@daneah daneah requested a review from a team as a code owner March 13, 2024 01:46
@daneah daneah requested review from brentswisher, sirrah-tam and mtorres3 and removed request for a team March 13, 2024 01:46
@daneah daneah changed the title Chore/update deps latest min Update dependencies to latest compatible versions Mar 13, 2024
@daneah daneah merged commit 976ac61 into develop Mar 13, 2024
11 checks passed
@daneah daneah deleted the chore/update-deps-latest-min branch March 13, 2024 12:48
daneah added a commit that referenced this pull request Mar 14, 2024
When I did the updates in #716, I had to pin this package to `0.9.0` to
keep things working without looking too deeply into the reason.

After that got merged and with some fresh cognitive capacity, I looked
into this and ultimately filed open-wc/custom-elements-manifest#242,
where the team was kind enough to guide me through what changed and what
the expectations are going forward for this format.

This change stops relying on the presence of `resolveInitializer`, which
is a leaky abstraction, and instead checks if there are any matching
variable values directly. I verified the output is identical, save for
the ordering of the exports in the built
`packages/pharos/src/react-components/index.ts` file, which is
definitely acceptable; I think they're even in alphabetical order, now.
daneah added a commit that referenced this pull request Mar 14, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
When I did the updates in #716, I had to pin this package to `0.9.0` to
keep things working without looking too deeply into the reason.

After that got merged and with some fresh cognitive capacity, I looked
into this and ultimately filed open-wc/custom-elements-manifest#242,
where the team was kind enough to guide me through what changed and what
the expectations are going forward for this format.

This change stops relying on the presence of `resolveInitializer`, which
is a leaky abstraction, and instead checks if there are any matching
variable values directly. I verified the output is identical, save for
the ordering of the exports in the built
`packages/pharos/src/react-components/index.ts` file, which is
definitely acceptable; I think they're even in alphabetical order, now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status/code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook: Controls revert themselves in some Docs pages, causing invalid state
2 participants