Add individual component exports #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added an exports key to the package.json, which made it so that components could only be imported from the root of the package. In some situations this is not desired as it makes it more difficult to share components between projects using module sharing and causes bloat in the bundle. This commit adds back the individual component exports.
brentswisher
requested review from
sirrah-tam,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: 42fe936 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
michael-iden
approved these changes
Apr 10, 2024
eslawski
approved these changes
Apr 10, 2024
satya-achanta-venkata
approved these changes
Apr 10, 2024
shoupeva-ithaka
approved these changes
Apr 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Fixes #738
How does this change work?
We recently added an
exportskey to the package.json, which madeit so that components could only be imported from the root of the
package. In some situations this is not desired as it makes it more
difficult to share components between projects using module sharing
and causes bloat in the bundle. This commit adds back the individual
component exports.
Additional context
I had considered removing the `exports1 key entirely as it looks like the initial use case (#212) is no longer valid, in that we explicitly don't want to , but adding the components was easy enough because it accepts a glob pattern so this seems like the best of both worlds, consumers can import them however they see fit for their application.