Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): update linting ignore patterns #754

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

daneah
Copy link
Member

@daneah daneah commented May 10, 2024

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
ESLint was finding built files, when they existed, and not ignoring them. This issue was two-fold:

  1. The patterns weren't right per ESLint's new expectation for relative and recursive patterns, so the files would be considered if present
  2. The ignores were only configured in our main config, such that other plugins and so on would not use the list of ignores

How does this change work?
Updating the patterns and putting them in their own object at the start of the final config returns us to a fast, passing lint even in the presence of built files.

Additional context
Follows up #753

ESLint was finding built files, when they existed, and not ignoring
them. This issue was two-fold:

1. The patterns weren't right per ESLint's new expectation for relative
   and recursive patterns, so the files would be considered if present
2. The ignores were only configured in our main config, such that other
   plugins and so on would not use the list of ignores

Updating the patterns and putting them in their own object at the start
of the final config returns us to a fast, passing lint even in the
presence of built files.
Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 6798334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daneah daneah marked this pull request as ready for review May 10, 2024 19:54
@daneah daneah requested a review from a team as a code owner May 10, 2024 19:54
@daneah daneah requested review from sirrah-tam, jialin-he, mtorres3 and brentswisher and removed request for a team May 10, 2024 19:54
Copy link
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.56 KB (0%)

@daneah daneah merged commit 9331f3a into develop May 10, 2024
11 checks passed
@daneah daneah deleted the fix/linting-ignores branch May 10, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants