Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create form data export #770

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

ymouzakis
Copy link
Contributor

@ymouzakis ymouzakis commented Jun 20, 2024

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Adds an export for createForumData which is used in other projects.
Closes #769

How does this change work?
Add export to list in package.json

Additional context
Add any other context here.

@ymouzakis ymouzakis added bug dependencies Pull requests that update a dependency file labels Jun 20, 2024
@ymouzakis ymouzakis requested a review from a team as a code owner June 20, 2024 16:09
@ymouzakis ymouzakis requested review from daneah, sirrah-tam and mtorres3 and removed request for a team June 20, 2024 16:09
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 2ba345f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ymouzakis ymouzakis changed the title Bugfix/create form data export bugfix/create form data export Jun 20, 2024
@ymouzakis ymouzakis requested a review from brentswisher June 20, 2024 16:10
@daneah daneah changed the title bugfix/create form data export Create form data export Jun 20, 2024
@daneah daneah added note/bug fix infrastructure and removed bug dependencies Pull requests that update a dependency file labels Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.63 KB (0%)

"profile": "https://github.com/ymouzakis",
"contributions": [
"code"
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding myself as a wickie if that's cool

Copy link
Contributor

@brentswisher brentswisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymouzakis - I have a meeting right now but I'll cut a new release as soon as that is over

@brentswisher brentswisher merged commit 38b9506 into develop Jun 20, 2024
7 checks passed
@brentswisher brentswisher deleted the bugfix/create-form-data-export branch June 20, 2024 17:44
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createFormData is not exported
4 participants