Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pharos site storybook links #781

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

brentswisher
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • [] Component status page up to date?

What does this change address?
pharos.jstor.org currently points to storybook using something like https://pharos.jstor.org/storybook/?path=/story/web-components_components-alert--base which is not a valid url.

Screenshot 2024-07-19 at 11 56 36 AM

How does this change work?
Updates the storybook links to point to --docs instead of --base

Additional context
I also fixed a bad filename for a component that got missed in #776

@brentswisher brentswisher self-assigned this Jul 19, 2024
@brentswisher brentswisher requested a review from a team as a code owner July 19, 2024 15:59
@brentswisher brentswisher requested review from daneah, sirrah-tam and mtorres3 and removed request for a team July 19, 2024 15:59
Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: ee28e6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos-site Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.73 KB (0%)

@brentswisher brentswisher merged commit 4f8c37d into develop Jul 19, 2024
7 checks passed
@brentswisher brentswisher deleted the fix/pharos-site-storybook-link branch July 19, 2024 17:52
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants