Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the table caption warning to recommend correct attribute to visually hide the caption #801

Merged

Conversation

brentswisher
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
If you don't provide a table caption, there is an error thrown with directions how to fix it:

Table must have an accessible name. Please provide a caption for the table using the caption attribute. You can hide the caption visually by setting the hide-caption-visually property.

However, the correct property to visually hide it is actually just hide-caption not hide-caption-visually

How does this change work?
Updates the error message to include the correct property in the error message

@brentswisher brentswisher self-assigned this Aug 29, 2024
@brentswisher brentswisher requested a review from a team as a code owner August 29, 2024 14:23
@brentswisher brentswisher requested review from daneah, sirrah-tam and mtorres3 and removed request for a team August 29, 2024 14:23
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 17900dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 29, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 65.88 KB (+0.02% 🔺)

@brentswisher brentswisher force-pushed the bugfix/incorrect-attribute-in-table-caption-warning branch from b1b5ff6 to 17900dd Compare August 30, 2024 16:16
@brentswisher brentswisher merged commit 8eefe16 into develop Aug 30, 2024
11 checks passed
@brentswisher brentswisher deleted the bugfix/incorrect-attribute-in-table-caption-warning branch August 30, 2024 17:03
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants