Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Add design tokens and update default header background #810

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

brentswisher
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Close #806

How does this change work?
Adds new component level tokens for that table and updates the header to have a light gray background by default.

Additional context
New Default Header:

Screenshot 2024-08-30 at 2 42 49 PM

@brentswisher brentswisher self-assigned this Aug 30, 2024
@brentswisher brentswisher requested a review from a team as a code owner August 30, 2024 18:44
@brentswisher brentswisher requested review from daneah, sirrah-tam and mtorres3 and removed request for a team August 30, 2024 18:44
Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: c7c79ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 65.92 KB (+0.07% 🔺)

@brentswisher brentswisher merged commit 52f56af into develop Sep 3, 2024
11 checks passed
@brentswisher brentswisher deleted the feature/update-table-background branch September 3, 2024 12:19
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: The header should be more visually distinct from the rest of the table cells
3 participants