Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea: Update min height styling #833

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mariadevadoss
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Update min height styling of text area so that right height is set when rows value is 1

How does this change work?
Updating min height styling of text area so that right height is set when rows value is 1

Additional context
https://ithaka.slack.com/archives/CQGGXAUMA/p1731612431204939

@mariadevadoss mariadevadoss requested a review from a team as a code owner November 15, 2024 16:58
@mariadevadoss mariadevadoss requested review from sirrah-tam, jialin-he and mtorres3 and removed request for a team November 15, 2024 16:58
Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 41c15d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 66.77 KB (0%)

@daneah daneah changed the title Update min height styling of text area Textarea: Update min height styling Nov 21, 2024
@daneah daneah merged commit fa946f2 into develop Nov 21, 2024
11 checks passed
@daneah daneah deleted the bugfix/update-textarea-min-height branch November 21, 2024 14:51
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants