Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidenav): update close button #844

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

jialin-he
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
before:
image

after:
image

How does this change work?
Change the icon and position.

@jialin-he jialin-he requested a review from a team as a code owner January 24, 2025 18:28
@jialin-he jialin-he requested review from daneah, sirrah-tam and mtorres3 and removed request for a team January 24, 2025 18:28
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: d57ed38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 24, 2025

size-limit report 📦

Path Size
packages/pharos/lib/index.js 66.81 KB (+0.03% 🔺)

@jialin-he jialin-he merged commit ecff778 into develop Jan 24, 2025
10 of 11 checks passed
@jialin-he jialin-he deleted the feat/nav-close-button branch January 24, 2025 20:27
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants