Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pos_debt_notebook unit-tour-test #1104

Open
wants to merge 3 commits into
base: 11.0
Choose a base branch
from
Open

pos_debt_notebook unit-tour-test #1104

wants to merge 3 commits into from

Conversation

fedoranvar
Copy link

No description provided.

Copy link
Contributor

@itpp-bot itpp-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 installable modules are updated:

├─ pos_category_multi/
|  ├─ README.rst
|  ├─ __init__.py
|  ├─ __manifest__.py
|  └─ doc/
|     └─ changelog.rst
├─ pos_debt_notebook/
|  ├─ README.rst
|  ├─ static/
|  |  └─ src/
|  |     └─ js/
|  |        └─ test_pos_debt.js
|  └─ tests/
|     └─ test_pos_debt.py
└─ pos_debt_notebook_sync/
   ├─ __manifest__.py
   ├─ static/
   |  └─ src/
   |     └─ js/
   |        └─ test_debt_sync.js
   ├─ tests/
   |  ├─ __init__.py
   |  └─ test_debt_sync.py
   └─ views/
      └─ assets.xml

Not installable modules remain unchanged.

sent by ✌️ Odoo Review Bot

pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
Copy link
Contributor

@KolushovAlexandr KolushovAlexandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add a scenario with an order paid with all credit payment methods altogether
  • check the balance was changed (in the backend) after all scenarios with validated orders (better use different partners or make several tours)
  • request a review only after tests are passed on travis

pos_debt_notebook/tests/test_pos_debt.py Outdated Show resolved Hide resolved
pos_category_multi/__manifest__.py Outdated Show resolved Hide resolved
pos_category_multi/__manifest__.py Outdated Show resolved Hide resolved
`1.0.2`
-------

**Improvement:** After install didn't update categories if there were any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a fix, its improvement write smth according to it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pos_debt_notebook/tests/test_pos_debt.py Outdated Show resolved Hide resolved
// Scenario: Proceed order with autopay-button (bottom-left corner)
function scene_7(steps, client, price) {
return steps.concat(
add_product_to_order("Miscellaneous"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not do those repetitive steps, you can change prices for some particular products in python before tours start and save some time on it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pos_debt_notebook/static/src/js/test_pos_debt.js Outdated Show resolved Hide resolved
@KolushovAlexandr
Copy link
Contributor

Also ensure the pos_debt_notebook_sync does not repeat the whole steps of pos_debt. Some simple stuff as initial_scene tests is enough for it

@fedoranvar
Copy link
Author

Also ensure the pos_debt_notebook_sync does not repeat the whole steps of pos_debt. Some simple stuff as initial_scene tests is enough for it

At the moment, don't have a clue about how to do it. To be exactly, "how to pass arguments from python to js-tour-test"

Copy link
Contributor

@KolushovAlexandr KolushovAlexandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. AssertionError: error tour tour_pos_debt_notebook failed at step .button.next.highlight:contains("validate")
  2. pos debt sync tests

pos_debt_notebook/tests/test_pos_debt.py Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Outdated Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Outdated Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Outdated Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Outdated Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Outdated Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Show resolved Hide resolved
pos_debt_notebook/tests/test_pos_debt.py Show resolved Hide resolved
@trojikman trojikman added the 11.0 label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants