Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video: try using the TvHtml5ScreenEmbed client type to get videos. #4737

Closed
wants to merge 1 commit into from

Conversation

ashley0143
Copy link

this pull requests tries fixing the #4734 issue by using the tv client.

@ashley0143 ashley0143 requested a review from a team as a code owner June 7, 2024 13:54
@ashley0143 ashley0143 requested review from syeopite and removed request for a team June 7, 2024 13:54
@ashley0143
Copy link
Author

needs testing

@unixfox
Copy link
Member

unixfox commented Jun 7, 2024

No that's not the intended fix. We want to still use the ANDROID client or the WEB client with a proper fix.

@unixfox unixfox closed this Jun 7, 2024
@ggtylerr
Copy link

ggtylerr commented Jun 7, 2024

Should at the very least fix up the error handling on the "last hope" parser, switching to it if there's an actual error rather than just a null response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants