Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tank material pointing to deleted copy of PBRLighting #2360

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

yaRnMcDonuts
Copy link
Member

@yaRnMcDonuts yaRnMcDonuts commented Feb 3, 2025

While preparing to cut the next alpha release, I did a final engine build and ran some important pbr engine tests/examples, and I ran into a crash with the SimplePBRTest example.

I had forgotten that riccardo had changed this tank material to test the new modular pbr shaders when the shaders were in a separate directory for preliminary testing last year.

But now the duplicated modular shaders were deleted (and have replaced the main PBR shader), so this test crashes with an assetNotFoundException, and just needed updated to point back to Common/MatDefs/Light/PBRLighting.j3md.

In the process of cutting the next alpha release, I ran into a crash with the SimplePBRTest example.

This tank material was previously changed to test the new modular pbr shaders when the shaders were in a separate directory for preliminary testing last year.

But now they were deleted (and have replaced the main PBR shader) so this test crashes with an assetNotFoundException, and just needed updated to point back to Common/MatDefs/Light/PBRLighting.j3md
@yaRnMcDonuts
Copy link
Member Author

yaRnMcDonuts commented Feb 3, 2025

I had to update a few more asset paths to point to the correct place, I moved things around alot after i started testing on my larger projects, and forgot to revert them back to point to the common/ directories.

But I've now tested PBRTerrainTest, TestPBRSimple, TestPBRLighting, and PBRTerrainAdvancedTest.

All 4 of these PBR tests/examples now run with the new modular PBR shader.

However, the recent changes to modularize the terrain shaders were only applied to AdvancedPBRTerrain.j3md, so this has temporarily caused PBRTerrainTest and the non-advanced pbr terrain shader (PBRTerrain.j3md) to crash for the time being, and it is not advised to use PBRTerrain.j3md until it is modularized as well, which will come shortly after AdvancedPBRTerrain.j3md is done being tested and finalized in the next alpha release that will be out in a few hours.

@yaRnMcDonuts yaRnMcDonuts merged commit 1f31c14 into master Feb 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant