jack_lsp: Fix buffer overflow for --server argument #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the copied `optarg` there are only chars from the argument, no string termination `\0` char. That causes the following code to go beyond the variable memory bound. This change adds one extra char allocation for the `server_name` variable and puts `\0` string termination char to the last char. Fixes jackaudio#88
unclechu
commented
Jun 13, 2024
| @@ -122,7 +122,8 @@ main (int argc, char *argv[]) | |||
| while ((c = getopt_long (argc, argv, "s:AclLphvtuU", long_options, &option_index)) >= 0) { | |||
| switch (c) { | |||
| case 's': | |||
| server_name = (char *) malloc (sizeof (char) * strlen(optarg)); | |||
| server_name = (char *) malloc (sizeof (char) * (strlen(optarg) + 1)); | |||
| server_name[strlen(optarg)] = '\0'; | |||
There was a problem hiding this comment.
Following the #88 (comment) comment this line might not be necessary.
Suggested change
| server_name[strlen(optarg)] = '\0'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the copied
optargthere are only chars from the argument, no string termination\0char. That causes the following code to go beyond the variable memory bound.This change adds one extra char allocation for the
server_namevariable and puts\0string termination char to the last char.Fixes #88