One should avoid gettimeofday for purposes of timestamping. #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cause it is possible to mis calculate time between timestamps if something/user changes system date. The monotonic time is much more safer to use for timestamp purposes.
|
FWIW ntpd and chrony will drive you insane over this too. Duplicated? #412 |
|
This PR doesn't remove the use of Fun fact: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is possible to mis calculate time between timestamps
if something/user changes system date. The monotonic time is
much more safer to use for timestamp purposes.
Better to let monotonic time as default timestamp time.