Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][WIP] posix: Set mutex type to PTHREAD_MUTEX_ERRORCHECK #613

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fps
Copy link
Contributor

@fps fps commented Jul 9, 2020

When looking for a way to debug the deadlock in #395 I stumbled across this advisory:

https://wiki.sei.cmu.edu/confluence/display/c/POS04-C.+Avoid+using+PTHREAD_MUTEX_NORMAL+type+mutex+locks

In the end it didn't detect the deadlock (which is not a proof of it not existing) but I'll leave the PR here for your consideration. Might be helpful in the future..

@falkTX
Copy link
Member

falkTX commented Oct 11, 2020

having it always on is not the most useful, do we really need it all the time?
If you wrap it around a #ifdef BUILD_DEBUG (so that debug builds have it, otherwise everything still the same) I will merge the PR. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants