Use XDG_STATE_HOME for jackdbus logs #967
Conversation
dbus/jackdbus.c
Outdated
| @@ -694,7 +694,7 @@ pathname_cat(const char *pathname_a, const char *pathname_b) | |||
| bool | |||
| paths_init() | |||
| { | |||
| const char *home_dir, *xdg_config_home, *xdg_log_home; | |||
| const char *home_dir, *xdg_config_home, *xdg_state_home; | |||
There was a problem hiding this comment.
Tabs are the wrong indentation style here. The whole file contains just a handful of tab-indented lines (which have been like that since 2008), all the rest is indented with 4 spaces. Now would be a good time to not replicate the exact original indentation for the changed lines, but instead to fix all of it. Please use 4 spaces for your changes,, and also fix the remaining old tab-indented lines in the function, there's like 5 of them.
dbus/jackdbus.c
Outdated
| xdg_state_home = getenv("XDG_STATE_HOME"); | ||
| if (xdg_state_home == NULL) | ||
| { | ||
| if (!(xdg_state_home = pathname_cat(home_dir, DEFAULT_XDG_STATE))) goto fail; |
There was a problem hiding this comment.
This leaks memory and is problematic in general. A pointer from getenv() shouldn't be free() d, but pathname_cat() returns an allocated buffer pointer which definitely should. If you use a single pointer variable like this, you lose information about whether you need to call free() on it before returning.
That being said, none of the temporary allocations from pathname_cat() are ever freed. The whole thing seems to have been leaky since 2008.
…xdg_state_home variables
Fixes #402
In that bug, it's mentioned that Debian has an $XDG_STATE_HOME extension for that purpose. Well, it's been added to version 0.8 of the specification (8 May 2021) with the description:
It's been a part of the official specification for almost three years and other applications use it, so it should be safe to use it and not add unnecessary files and directories to $HOME.