Add unit test for delete-info
#1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit test deletes a few files including one with a name that is invalid UTF-8. It then tests if the deleted names are correctly returned. The test is disabled for the usual targets, such as macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch should be ready to merged upstream after rebasing. I tried rebasing it myself, but GitHub yelled at me so I decided to just implement the unit test instead. There's only small merge conflict with upstream that I can fix after the holidays if I figure out why GitHub doesn't like it.
The ultimate goal is to work on: pop-os/cosmic-files#604