feat(explorer): collapsible mobile explorer #1471

saberzero1 · 2024-10-01T20:16:32Z

Screencast.from.2024-10-01.23-34-59.webm

Progress

saberzero1 · 2024-10-01T23:04:43Z

@aarnphm I suppose this is another PR with a breaking change, as the Explorer component is no longer DesktopOnly. Keeping it DesktopOnly keeps the functionality the same as currently, but makes the mobile Explorer view hidden by default.

aarnphm

cc jacky on this.

quartz.layout.ts

quartz/components/Explorer.tsx

quartz/components/scripts/explorer.inline.ts

saberzero1 · 2024-10-02T09:58:44Z

cc jacky on this.

Thanks for the review.

I think most of your feedback is valid. I'll do some more experimenting to reduce redundant code/hacks.

I have another implementation that is a lot more sophisticated, but requires the navigation tree to be included twice. I remember that this is something we explicitly want to avoid, mostly due to accessibility concerns.

I'll ping you once I am satisfied with my changes.

saberzero1 · 2024-10-03T18:04:27Z

@aarnphm I believe I have addressed your feedback.

Once the code changes are approved, I'll update the documentation and restore the default configuration (DesktopOnly on Explorer).

aarnphm

cc jacky on this as well 😄

quartz/components/Explorer.tsx

quartz/components/ExplorerNode.tsx

quartz/components/Footer.tsx

quartz/components/ExplorerNode.tsx

quartz/components/Footer.tsx

Co-authored-by: Aaron Pham <[email protected]>

saberzero1 · 2024-10-26T16:02:26Z

Screencast.from.2024-10-26.17-58-29.webm

quartz/components/styles/explorer.scss

Stephen-X · 2024-11-02T09:54:55Z

Bug report: Because explorer is hidden in folder index pages, the mobile explorer button also disappears from title bar.

saberzero1 · 2024-11-02T10:05:51Z

Bug report: Because explorer is hidden in folder index pages, the mobile explorer button also disappears from title bar.

Can you check if this stil l occurs when the explorer is added to listpages in quartz.layout.ts?

Stephen-X · 2024-11-02T10:13:20Z

Bug report: Because explorer is hidden in folder index pages, the mobile explorer button also disappears from title bar.

Can you check if this stil l occurs when the explorer is added to listpages in quartz.layout.ts?

Sorry that was a careless bug report. My setup mistake while testing the PR in different cases. I forgot I made explorer desktop-only for ListPages before this PR because the whole explorer would otherwise appear in the title bar.

The implementation comes from the following pull request, which has not been merged at the time of this commit: jackyzha0/quartz#1471

PatMulligan · 2025-01-26T12:44:11Z

Big fan of this PR 📣

Copilot

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

quartz/components/styles/explorer.scss: Language not supported

Comments suppressed due to low confidence (1)

quartz/components/Explorer.tsx:47

The variable 'jsonTree' is being used without being declared in the scope of the 'constructFileTree' function. Ensure 'jsonTree' is declared in the appropriate scope.

let jsonTree: string

quartz/components/scripts/explorer.inline.ts

quartz/components/Explorer.tsx

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)

quartz/components/styles/explorer.scss: Language not supported

saberzero1 · 2025-02-01T18:07:06Z

@aarnphm this should be ready now.

aarnphm

I have one comments,otherwise LGTM

quartz/components/styles/explorer.scss

* Added plugin to support image captions * Added plugin to support image lightbox * Fixed style issues to resolve build failure * GLightbox shows close button by default * Fixed GLightbox not reloaded in SPA mode * chore(styles): omit sass deprecation warnings (jackyzha0#1737) update to newer API * chore(deps): bump the production-dependencies group across 1 directory with 3 updates (jackyzha0#1744) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(graph): enable radial mode (jackyzha0#1738) * feat(explorer): collapsible mobile explorer (jackyzha0#1471) Co-authored-by: Aaron Pham <[email protected]> * 测试效果 --------- Co-authored-by: Stephen Tse <[email protected]> Co-authored-by: Anton Bulakh <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Pham <[email protected]> Co-authored-by: Emile Bangma <[email protected]> Co-authored-by: Aaron Pham <[email protected]>

Co-authored-by: Aaron Pham <[email protected]>

Rewrite mobile explorer

a190cba

saberzero1 mentioned this pull request Oct 1, 2024

Mobile Explorer #1441

Closed

saberzero1 added 5 commits October 1, 2024 23:24

Finished mobile explorer

139573f

Fix folder/tag page

836f2a8

Cleanup

526e50a

Combine into single explorer tree

7d404ac

Restore mobile button position

1e8e3e6

saberzero1 marked this pull request as ready for review October 1, 2024 23:02

saberzero1 mentioned this pull request Oct 1, 2024

feat: responsive design grid #1354

Merged

7 tasks

aarnphm reviewed Oct 2, 2024

View reviewed changes

aarnphm requested a review from jackyzha0 October 2, 2024 03:44

saberzero1 added 6 commits October 3, 2024 19:00

Merge branch 'jackyzha0:v4' into explorer

60aae86

classNames usage

ad1a7d7

Clean up redundant code

4e8e251

Addressed feedback

0513ad4

Cleanup

5fd0f17

Restore position of functions

356647f

aarnphm approved these changes Oct 3, 2024

View reviewed changes

quartz/components/Explorer.tsx Outdated Show resolved Hide resolved

quartz/components/ExplorerNode.tsx Outdated Show resolved Hide resolved

quartz/components/Footer.tsx Outdated Show resolved Hide resolved

quartz/components/ExplorerNode.tsx Outdated Show resolved Hide resolved

saberzero1 added 5 commits October 3, 2024 21:42

Revert Footer

835f6a0

Addressed feedback

26e0b43

Remove usePagePath

40ca67c

Prettier

ff9be50

Merge branch 'v4' into explorer

7e41e10

aarnphm reviewed Oct 4, 2024

View reviewed changes

quartz/components/Footer.tsx Outdated Show resolved Hide resolved

saberzero1 and others added 2 commits October 5, 2024 00:59

Update quartz/components/Footer.tsx

fda7b66

Co-authored-by: Aaron Pham <[email protected]>

Merge branch 'v4' into explorer

7416415

Stephen-X mentioned this pull request Oct 12, 2024

fix: Second ToC element not collapsible or highlight-able #1505

Open

Cleanup

8bb32c2

aarnphm self-requested a review October 26, 2024 17:25

Stephen-X reviewed Nov 2, 2024

View reviewed changes

quartz/components/styles/explorer.scss Show resolved Hide resolved

Icon spacing

70cf007

MihailKovachev approved these changes Dec 7, 2024

View reviewed changes

MihailKovachev added a commit to MihailKovachev/Razon that referenced this pull request Dec 7, 2024

Implemented a collapsible explorer for mobile

512f480

The implementation comes from the following pull request, which has not been merged at the time of this commit: jackyzha0/quartz#1471

zelestis added a commit to zelestis/blog that referenced this pull request Dec 26, 2024

Add jackyzha0/quartz#1471

4c336b5

cromelex mentioned this pull request Jan 21, 2025

Explorer cromelex/pages-garden#3

Merged

saberzero1 added 2 commits February 1, 2025 18:20

Merge branch 'v4' into explorer

9b8dec0

SASS styling fixes

a1c36ec

saberzero1 requested a review from Copilot February 1, 2025 17:45

Copilot AI reviewed Feb 1, 2025

View reviewed changes

quartz/components/scripts/explorer.inline.ts Outdated Show resolved Hide resolved

quartz/components/scripts/explorer.inline.ts Show resolved Hide resolved

quartz/components/Explorer.tsx Outdated Show resolved Hide resolved

saberzero1 added 3 commits February 1, 2025 17:56

Remove unused parameter

849e8ac

Copilot nitpick

9786ead

Prefer compatibility

e31527a

saberzero1 requested a review from Copilot February 1, 2025 18:04

Copilot AI reviewed Feb 1, 2025

View reviewed changes

aarnphm approved these changes Feb 1, 2025

View reviewed changes

quartz/components/styles/explorer.scss Show resolved Hide resolved

aarnphm merged commit 91189df into jackyzha0:v4 Feb 3, 2025
5 checks passed

Krutik460 pushed a commit to Krutik460/brain that referenced this pull request Feb 7, 2025

feat(explorer): collapsible mobile explorer (jackyzha0#1471)

19853af

Co-authored-by: Aaron Pham <[email protected]>

zh30 pushed a commit to zh30/zhanghe.date that referenced this pull request Feb 18, 2025

feat(explorer): collapsible mobile explorer (jackyzha0#1471)

a7e627e

Co-authored-by: Aaron Pham <[email protected]>

Nasr-905 pushed a commit to Nasr-905/cerebrum-secundum that referenced this pull request Feb 21, 2025

feat(explorer): collapsible mobile explorer (jackyzha0#1471)

2b4f872

Co-authored-by: Aaron Pham <[email protected]>

saberzero1 deleted the explorer branch February 28, 2025 01:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(explorer): collapsible mobile explorer #1471

feat(explorer): collapsible mobile explorer #1471

saberzero1 commented Oct 1, 2024 •

edited

Loading

saberzero1 commented Oct 1, 2024

aarnphm left a comment

saberzero1 commented Oct 2, 2024

saberzero1 commented Oct 3, 2024

aarnphm left a comment

saberzero1 commented Oct 26, 2024

Stephen-X commented Nov 2, 2024

saberzero1 commented Nov 2, 2024

Stephen-X commented Nov 2, 2024 •

edited

Loading

PatMulligan commented Jan 26, 2025

Copilot AI left a comment

saberzero1 commented Feb 1, 2025

aarnphm left a comment

feat(explorer): collapsible mobile explorer #1471

feat(explorer): collapsible mobile explorer #1471

Conversation

saberzero1 commented Oct 1, 2024 • edited Loading

Progress

saberzero1 commented Oct 1, 2024

aarnphm left a comment

Choose a reason for hiding this comment

saberzero1 commented Oct 2, 2024

saberzero1 commented Oct 3, 2024

aarnphm left a comment

Choose a reason for hiding this comment

saberzero1 commented Oct 26, 2024

Stephen-X commented Nov 2, 2024

saberzero1 commented Nov 2, 2024

Stephen-X commented Nov 2, 2024 • edited Loading

PatMulligan commented Jan 26, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saberzero1 commented Feb 1, 2025

aarnphm left a comment

Choose a reason for hiding this comment

saberzero1 commented Oct 1, 2024 •

edited

Loading

Stephen-X commented Nov 2, 2024 •

edited

Loading