-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use older os to compiler so dynamic libraries work better #36
base: z80
Are you sure you want to change the base?
Conversation
Hmm can jacobly launch CI on this or something, to see if it builds as expected? |
It already built fine on my fork: https://github.com/mateoconlechuga/llvm-project/actions/runs/5039720221/jobs/9038047940 |
Ah great, merge time then 👀 |
waits 3 weeks for the merge |
Bump bump 😃 |
I'm going to fork the project at this point :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so I propose some modifications to just add the older OSes instead, since @jacobly0 said this (IRC).
06:06:40 <@jacobly> I have no problem with adding build configurations, but I'm not removing the existing ones
I guess now they have to be accepted so the PR gets updated, then jacobly can merge it.
@@ -10,7 +10,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
runs-on: [ubuntu-latest, macos-latest, windows-latest] | |||
runs-on: [ubuntu-20.04, macos-11, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: [ubuntu-20.04, macos-11, windows-latest] | |
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest] |
@@ -155,7 +155,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
runs-on: [ubuntu-latest, macos-latest, windows-latest] | |||
runs-on: [ubuntu-20.04, macos-11, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: [ubuntu-20.04, macos-11, windows-latest] | |
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest] |
@@ -280,7 +280,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
runs-on: [ubuntu-latest, macos-latest, windows-latest] | |||
runs-on: [ubuntu-20.04, macos-11, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: [ubuntu-20.04, macos-11, windows-latest] | |
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest] |
@@ -332,7 +332,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
runs-on: [ubuntu-latest, macos-latest, windows-latest] | |||
runs-on: [ubuntu-20.04, macos-11, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: [ubuntu-20.04, macos-11, windows-latest] | |
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest] |
@@ -382,7 +382,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
runs-on: [ubuntu-latest, macos-latest, windows-latest] | |||
runs-on: [ubuntu-20.04, macos-11, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: [ubuntu-20.04, macos-11, windows-latest] | |
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest] |
Well in addition to that now, I suppose we have to use |
Easier solution, regarding my last comment, no need to change the names, we can just upload the binaries if the currently running VM is the version we want. The other (newer) VMs will just continue to be there to test the build, that's fine. ( |
Well I put all the names differently for now, jacobly is able to merge it if it's ok https://github.com/adriweb/llvm-project/actions/runs/5335820947 |
I'm going to fork this into |
Well he said he'll do it so :P Also take the commit from my fork I guess, if you really want to do that. |
I guess I can wait a bit longer :) |
So, I did the thing to upload selected artifacts to a "nightly" pre-release like in CEmu or the toolchain, it works fine, as we can see in the release files :) |
b5b00fc
to
fcc1b7e
Compare
This can be closed, it was actually done in 5f8512f |
See relevant toolchain issue here: CE-Programming/toolchain#439