Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger] Add ability to edit port name and target port name in query and collector services #590

Merged
merged 8 commits into from
Jul 28, 2024
Merged

[jaeger] Add ability to edit port name and target port name in query and collector services #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce82310
Adding functionality to edit the collector service port name for admi…
vishukamble Jul 23, 2024
fd9ef1f
Adding functionality to edit the query service port name for admin po…
vishukamble Jul 23, 2024
36d7ee5
Adding default vaults to values.yaml for query and selector services.
vishukamble Jul 24, 2024
286dddf
incrementing chart version
vishukamble Jul 24, 2024
45b5932
Adding default values in values.yaml to render default values in helm…
vishukamble Jul 24, 2024
58eb2d4
removing quotes fromv values.yaml for collector
vishukamble Jul 24, 2024
530ed46
incrementing chart and fixing DCO requirement
vishukamble Jul 24, 2024
d672983
fixing typo in version in chart.yaml
vishukamble Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/jaeger/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 1.53.0
description: A Jaeger Helm chart for Kubernetes
name: jaeger
type: application
version: 3.1.1
version: 3.1.2
# CronJobs require v1.21
kubeVersion: ">= 1.21-0"
keywords:
Expand Down
4 changes: 2 additions & 2 deletions charts/jaeger/templates/collector-svc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ spec:
protocol: TCP
targetPort: {{ .Values.collector.service.otlp.http.name }}
{{- end }}
- name: admin
- name: {{ .Values.collector.service.admin.name }}
port: 14269
targetPort: admin
targetPort: {{ .Values.collector.service.admin.targetPort }}
selector:
{{- include "jaeger.selectorLabels" . | nindent 4 }}
app.kubernetes.io/component: collector
Expand Down
4 changes: 2 additions & 2 deletions charts/jaeger/templates/query-svc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ spec:
port: 16685
protocol: TCP
targetPort: grpc
- name: admin
- name: {{ .Values.query.service.admin.name }}
port: 16687
protocol: TCP
targetPort: admin
targetPort: {{ .Values.query.service.admin.targetPort }}
selector:
{{- include "jaeger.selectorLabels" . | nindent 4 }}
app.kubernetes.io/component: query
Expand Down
6 changes: 6 additions & 0 deletions charts/jaeger/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,9 @@ collector:
# name: otlp-http
# port: 4318
# nodePort:
admin:
name: admin
targetPort: admin
ingress:
enabled: false
# For Kubernetes >= 1.18 you should specify the ingress-controller via the field ingressClassName
Expand Down Expand Up @@ -693,6 +696,9 @@ query:
# targetPort: 8080
# Specify a specific node port when type is NodePort
# nodePort: 32500
admin:
name: admin
targetPort: admin
ingress:
enabled: false
# For Kubernetes >= 1.18 you should specify the ingress-controller via the field ingressClassName
Expand Down