Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage calculation and badge #127

Merged
merged 9 commits into from
Jan 25, 2025

Conversation

skirtan1
Copy link
Contributor

Which problem is this PR solving?

Enhancements for #6572

Description of the changes

  • Use retry upload action from main branch
  • Delete lines for model.pb.go from coverage
  • add badge to readme

How was this change tested?

Checklist

@skirtan1 skirtan1 changed the title [jaeger-idl] add coverage calculation and badge add coverage calculation and badge Jan 23, 2025
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Shreyas Kirtane <[email protected]>
Signed-off-by: Shreyas Kirtane <[email protected]>
.codecov.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Shreyas Kirtane <[email protected]>
@yurishkuro yurishkuro changed the title add coverage calculation and badge Add coverage calculation and badge Jan 24, 2025
@yurishkuro
Copy link
Member

@skirtan1 I think you will need to go back to your initial version of using a sub-action, because the workflow is failing with an error which I think is not solved in the retry-action (according to Wandalen/wretry.action#115)

Signed-off-by: Shreyas Kirtane <[email protected]>
@yurishkuro
Copy link
Member

I don't understand why it fails here
image

but works fine in the jaeger repo
image

@yurishkuro
Copy link
Member

let's try with 3.7.0

Signed-off-by: Yuri Shkuro <[email protected]>
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (3e525d7) to head (1f563c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #127       +/-   ##
==========================================
+ Coverage   8.33%   87.85%   +79.51%     
==========================================
  Files         16       12        -4     
  Lines       7830      568     -7262     
==========================================
- Hits         653      499      -154     
+ Misses      7135       67     -7068     
+ Partials      42        2       -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 8a54f16 into jaegertracing:main Jan 25, 2025
6 checks passed
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants