-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate and commit Go code for zipkincore.thrift #129
Generate and commit Go code for zipkincore.thrift #129
Conversation
Signed-off-by: nabil salah <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 12 12
Lines 568 568
=======================================
Hits 499 499
Misses 67 67
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: nabil salah <[email protected]>
@yurishkuro is this what is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exclude thrift-gen from Go linting
Signed-off-by: nabil salah <[email protected]>
@yurishkuro is this okay now? |
Signed-off-by: Yuri Shkuro <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test