Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger v2] Service Performance Monitoring #5632

Closed
yurishkuro opened this issue Jun 15, 2024 · 1 comment
Closed

[jaeger v2] Service Performance Monitoring #5632

yurishkuro opened this issue Jun 15, 2024 · 1 comment
Labels
v2

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jun 15, 2024 •
edited
Loading

Part of #5240

Jaeger-v1 implements a functionality known as SPM, but it requires a separately running OpenTelemetry Collector to produce metrics out of spans using SpanMetrics Connector. Since Jaeger-v2 is built on top of OTEL Collector, we can run SpanMetrics Connector directly in the Jaeger binary and simplify the setup for the users.

  • Expected Outcome: Achieve parity in SPM of jaeger-v2 compared to jaeger-v1. Implement integration tests. Update documentation accordingly.
  • Extra credit: implement metrics reader directly on top of Elasticsearch/Opensearch and bypass the need for Prometheus.
@yurishkuro yurishkuro converted this from a draft issue Jun 15, 2024
@yurishkuro yurishkuro added the v2 label Jun 15, 2024
@yurishkuro yurishkuro mentioned this issue Jun 15, 2024
Closed
3 tasks
@FlamingSaint FlamingSaint moved this from Todo to In Progress in Jaeger V2 Jun 17, 2024
This was referenced Jun 26, 2024
Closed
Merged
Merged
@FlamingSaint FlamingSaint mentioned this issue Jul 8, 2024
Merged
3 tasks
yurishkuro pushed a commit that referenced this issue Jul 8, 2024
@FlamingSaint
Cleanup the Prometheus config (#5720)
295293c 
## Which problem is this PR solving?
- Part of #5632

## Description of the changes
- Cleaned up the Prometheus config
- Removed namespaceConfig as its not needed for a metrics storage

## How was this change tested?
- `make test`

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
<s> - [ ] I have added unit tests for the new functionality </s>
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: FlamingSaint <[email protected]>
yurishkuro added a commit that referenced this issue Jul 24, 2024
@FlamingSaint @yurishkuro
Enable SPM in Jaeger v2 (#5681)
d8b2110 
## Which problem is this PR solving?
- This PR is a part of the issue #5632 

## Description of the changes
- Added a new docker-compose file 
- Added the configuration file which will be used for enabling SPM in v2

## How was this change tested?
- Run `make dev-v2` inside `docker-compose/monitor`

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: Raghuram Kannan <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
@FlamingSaint FlamingSaint mentioned this issue Jul 25, 2024
Closed
4 tasks
@FlamingSaint FlamingSaint mentioned this issue Aug 16, 2024
Closed
4 tasks
@yurishkuro
Copy link
Member Author

Separate issue #5608 opened for integration tests, considering this one finished.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Jaeger V2 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2
Projects
Jaeger V2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Enable SPM in Jaeger v2 FlamingSaint/jaeger
1 participant
@yurishkuro