-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate reason for zero values in SPM metrics #5853
Conversation
Signed-off-by: FlamingSaint <[email protected]>
local zero_count=0 | ||
local expected_max_zero_count=4 | ||
local flag=false # Becomes true after first non-zero value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
local flag=false # Becomes true after first non-zero value | |
local non_zero_found=false |
We already know that this causes failures, what are you trying to achieve with this change? How does it help with debugging? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5853 +/- ##
==========================================
+ Coverage 96.66% 96.79% +0.13%
==========================================
Files 342 342
Lines 16521 16522 +1
==========================================
+ Hits 15970 15993 +23
+ Misses 362 341 -21
+ Partials 189 188 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I created this PR mainly to keep track of the changes and the discussion on how to solve this problem. |
Which problem is this PR solving?
Description of the changes
How was this change tested?
make dev-v2
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test