Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate reason for zero values in SPM metrics #5853

Closed
wants to merge 1 commit into from

Conversation

FlamingSaint
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Added changes to the spm script to detect zero values occurring in the middle

How was this change tested?

  • make dev-v2

Checklist

@FlamingSaint FlamingSaint requested a review from a team as a code owner August 16, 2024 16:49
@dosubot dosubot bot added the docker Pull requests that update Docker code label Aug 16, 2024
local zero_count=0
local expected_max_zero_count=4
local flag=false # Becomes true after first non-zero value
Copy link
Member

@yurishkuro yurishkuro Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
local flag=false # Becomes true after first non-zero value
local non_zero_found=false

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Aug 16, 2024
@yurishkuro
Copy link
Member

We already know that this causes failures, what are you trying to achieve with this change? How does it help with debugging?

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (2c4aa39) to head (b49d05e).
Report is 162 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5853      +/-   ##
==========================================
+ Coverage   96.66%   96.79%   +0.13%     
==========================================
  Files         342      342              
  Lines       16521    16522       +1     
==========================================
+ Hits        15970    15993      +23     
+ Misses        362      341      -21     
+ Partials      189      188       -1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (-0.01%) ⬇️
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (-0.01%) ⬇️
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.02% <ø> (ø)
elasticsearch-8.x-v2 1.80% <ø> (-0.02%) ⬇️
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.14% <ø> (-0.01%) ⬇️
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.81% <ø> (-0.01%) ⬇️
memory_v2 1.81% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.89% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.80% <ø> (-0.02%) ⬇️
unittests 95.27% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FlamingSaint
Copy link
Member Author

We already know that this causes failures, what are you trying to achieve with this change? How does it help with debugging?

I created this PR mainly to keep track of the changes and the discussion on how to solve this problem.

@FlamingSaint FlamingSaint marked this pull request as draft August 16, 2024 17:04
@yurishkuro yurishkuro closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants