-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: kafka: cannot connect to TLS kafka with TLS + plaintext #6744
Comments
New here - picking this up. |
What instrumentation are you using for this setup? |
The kafka server is configured to work with SASL_SSL (only SSL/TLS listener are available with a signed certificate) with PLAIN authentication. My Kafka settings for Jaeger regarding the collector (same for ingester with consumer) are as follows:
|
We are seeing the same issue after updating to v1.66, v1.63 is working fine. Our configuration is via env variables:
|
This change fixes the Kafka TLS configuration to work correctly when tls.enabled flag is not provided but authentication=tls is set. Previously, TLS would not be enabled in this case. Changes: - TLS is now properly configured when authentication=tls, regardless of tls.enabled - Maintains backward compatibility with existing tls.enabled flag - Sets explicit insecure mode only when TLS is intentionally disabled Testing: - Added unit tests for TLS configuration scenarios - Verified with local Kafka cluster using TLS authentication - Tested with HotROD example application Resolves jaegertracing#6744 Signed-off-by: Amol Verma <[email protected]>
This change fixes the Kafka TLS configuration to work correctly when using plaintext authentication with TLS enabled. Previously, TLS would only be configured when authentication=tls, breaking SASL-SSL with PLAIN authentication. Changes: - Modified TLS configuration logic to support TLS with other authentication methods - Fixed SASL-SSL with PLAIN authentication scenario - Maintained backward compatibility with existing authentication methods - Restored pre-PR-6270 behavior for TLS configuration Resolves jaegertracing#6744 Signed-off-by: Amol Verma <[email protected]>
This change fixes the Kafka TLS configuration to work correctly when using plaintext authentication with TLS enabled. Previously, TLS would only be configured when authentication=tls, breaking SASL-SSL with PLAIN authentication. Resolves jaegertracing#6744 Signed-off-by: Amol Verma <[email protected]>
What happened?
Using v1.66.0
The PR 6270, change the way to load TLS on kafka.
Previously with kafka.[producer,consumer].authentication=plaintext if kafka.[producer,consumer].tls.enabled,
|| config.TLS.Enabled
was loadingsetTLSConfiguration
.The new code only loads TLS when authentication=tls, failing the connection with other authentication (plaintext/kerberos) + TLS (does not upgrade to TLS during authentication).
Basically it has become impossible to configure SASL-SSL with PLAIN.
Steps to reproduce
Expected behavior
It should work as before.
Relevant log output
Screenshot
No response
Additional context
No response
Jaeger backend version
v1.66.0
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
The text was updated successfully, but these errors were encountered: