[v2][storage] Refactor Storage API v2 To Match Changes in New Remote Storage #6765
Open
2 tasks done
Assignees
Labels
Comments
This was referenced Feb 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 24, 2025
…api (#6770) ## Which problem is this PR solving? - Towards #6765 ## Description of the changes - This PR changes the API of `FindTraceIDs` from returning `[]pcommon.TraceID` to returning a `FindTraceIDsChunk` that contains the trace IDs along with `Start` and `End` fields that are meant to serve as hints for some storage backends (e.g Tempo) that can optimize the queries when given a time range. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 27, 2025
…sts (#6779) ## Which problem is this PR solving? - Towards #6765 ## Description of the changes - This PR is a prelude to #6769. That PR was running into issues because a JSON type cannot be unmarshalled into the `pcommon.Map` type. In order to fix that, this PR decouples the `Query` in the integration test from `TraceQueryParams` so that we can accept queries as JSON and populate them into the `TraceQueryParams` as we see fit. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 27, 2025
## Which problem is this PR solving? - Towards #6765 ## Description of the changes - Updates `TraceQueryParams` to change the `Attributes` field from a `map[string]string` to `pcommon.Map` to accept typed attributes to match the Remote Storage API v2 being developed as part of #6629 ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 28, 2025
## Which problem is this PR solving? - Towards #6629 and #6765 ## Description of the changes - This PR makes the following changes to converge the v2 storage API with the v2 remote storage API - `NumTraces` -> `SearchDepth` - Update documentation for `TraceQueryParams` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #6629, we made some changes that diverge the API from
api_v3. This is a tracking ticket to make those same changes in the Storage API v2 as well.FindTraceIDsThe text was updated successfully, but these errors were encountered: