[refactor] Return start and end timestamps from FindTraceIDs in v2 api
#6770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6770 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 363 363
Lines 20675 20677 +2
=======================================
+ Hits 19852 19854 +2
Misses 628 628
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mahadzaryab1
commented
Feb 23, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
force-pushed
the
add-timestamps
branch
from
98fa913 to
049231b
Compare
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
FindTraceIDs in v2 apiFindTraceIDs in v2 api
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Feb 23, 2025
yurishkuro
reviewed
Feb 23, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Feb 23, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
renovate-bot
pushed a commit
to renovate-bot/jaegertracing-_-jaeger
that referenced
this pull request
Feb 24, 2025
…mote storage api (jaegertracing#6772) ## Which problem is this PR solving? - Towards jaegertracing#6629 ## Description of the changes - This is a copy of jaegertracing#6770 but for the v2 remote storage API ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
FindTraceIDsfrom returning[]pcommon.TraceIDto returning aFindTraceIDsChunkthat contains the trace IDs along withStartandEndfields that are meant to serve as hints for some storage backends (e.g Tempo) that can optimize the queries when given a time range.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test