Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2][storage] Move span reader decorator to storage factories #6280

Merged
merged 22 commits into from
Nov 30, 2024

Remove Unused Metrics Factory From ES Reader

214aac0
Select commit
Loading
Failed to load commit list.
Merged

[v2][storage] Move span reader decorator to storage factories #6280

Remove Unused Metrics Factory From ES Reader
214aac0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 30, 2024 in 1s

96.43% (target 95.00%)

View this Pull Request on Codecov

96.43% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 94.44444% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.43%. Comparing base (cedaeaa) to head (214aac0).

Files with missing lines Patch % Lines
plugin/storage/cassandra/factory.go 86.04% 4 Missing and 2 partials ⚠️
plugin/storage/es/factory.go 92.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6280    +/-   ##
========================================
  Coverage   96.43%   96.43%            
========================================
  Files         355      355            
  Lines       20165    20299   +134     
========================================
+ Hits        19446    19576   +130     
- Misses        530      532     +2     
- Partials      189      191     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.