Add unit test for OTLP receiver in jaeger-v1

cmd/collector/app/handler/grpc_handler.go

@@ -10,7 +10,6 @@ import (
 	"go.uber.org/zap"
 	"google.golang.org/grpc/codes"
 	_ "google.golang.org/grpc/encoding/gzip" // register zip encoding
-	"google.golang.org/grpc/metadata"
 	"google.golang.org/grpc/status"
 
 	"github.com/jaegertracing/jaeger-idl/model/v1"
@@ -97,22 +96,5 @@ func (c *batchConsumer) validateTenant(ctx context.Context) (string, error) {
 	if !c.tenancyMgr.Enabled {
 		return "", nil
 	}
-
-	md, ok := metadata.FromIncomingContext(ctx)
-	if !ok {
-		return "", status.Errorf(codes.PermissionDenied, "missing tenant header")
-	}
-
-	tenants := md.Get(c.tenancyMgr.Header)
-	if len(tenants) < 1 {
-		return "", status.Errorf(codes.PermissionDenied, "missing tenant header")
-	} else if len(tenants) > 1 {
-		return "", status.Errorf(codes.PermissionDenied, "extra tenant header")
-	}
-
-	if !c.tenancyMgr.Valid(tenants[0]) {
-		return "", status.Errorf(codes.PermissionDenied, "unknown tenant")
-	}
-
-	return tenants[0], nil
+	return tenancy.GetValidTenant(ctx, c.tenancyMgr)
 }

cmd/collector/app/span_processor_test.go

@@ -10,28 +10,43 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"net/http"
 	"reflect"
 	"slices"
+	"strings"
 	"sync"
 	"sync/atomic"
 	"testing"
 	"time"
 
 	"github.com/gogo/protobuf/jsonpb"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/collector/config/configgrpc"
+	"go.opentelemetry.io/collector/config/confighttp"
+	"go.opentelemetry.io/collector/config/confignet"
+	"go.opentelemetry.io/collector/pdata/ptrace"
+	otlptrace "go.opentelemetry.io/proto/otlp/collector/trace/v1"
+	tracepb "go.opentelemetry.io/proto/otlp/trace/v1"
 	"go.uber.org/zap"
+	"go.uber.org/zap/zaptest"
+	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials/insecure"
+	"google.golang.org/grpc/metadata"
 
 	"github.com/jaegertracing/jaeger-idl/model/v1"
 	"github.com/jaegertracing/jaeger-idl/thrift-gen/jaeger"
 	zc "github.com/jaegertracing/jaeger-idl/thrift-gen/zipkincore"
+	cFlags "github.com/jaegertracing/jaeger/cmd/collector/app/flags"
 	"github.com/jaegertracing/jaeger/cmd/collector/app/handler"
 	"github.com/jaegertracing/jaeger/cmd/collector/app/processor"
 	zipkinsanitizer "github.com/jaegertracing/jaeger/cmd/collector/app/sanitizer/zipkin"
 	"github.com/jaegertracing/jaeger/internal/metricstest"
 	"github.com/jaegertracing/jaeger/pkg/metrics"
 	"github.com/jaegertracing/jaeger/pkg/tenancy"
 	"github.com/jaegertracing/jaeger/pkg/testutils"
+	"github.com/jaegertracing/jaeger/storage_v2/tracestore/mocks"
 	"github.com/jaegertracing/jaeger/storage_v2/v1adapter"
 )
 
@@ -807,3 +822,213 @@ func TestSpanProcessorWithOnDroppedSpanOption(t *testing.T) {
 	require.EqualError(t, err, processor.ErrBusy.Error())
 	assert.Equal(t, []string{"op3"}, droppedOperations)
 }
+
+func optionsWithPorts(portHttp string, portGrpc string) *cFlags.CollectorOptions {
+	opts := &cFlags.CollectorOptions{
+		OTLP: struct {
+			Enabled bool
+			GRPC    configgrpc.ServerConfig
+			HTTP    confighttp.ServerConfig
+		}{
+			Enabled: true,
+			HTTP: confighttp.ServerConfig{
+				Endpoint:        portHttp,
+				IncludeMetadata: true,
+			},
+			GRPC: configgrpc.ServerConfig{
+				NetAddr: confignet.AddrConfig{
+					Endpoint:  portGrpc,
+					Transport: confignet.TransportTypeTCP,
+				},
+			},
+		},
+	}
+	return opts
+}
+
+func TestOTLPReceiverWithV2Storage(t *testing.T) {
+	tests := []struct {
+		name           string
+		requestType    string
+		tenant         string
+		expectedTenant string
+		expectedError  bool
+		executeRequest func(ctx context.Context, url string, tenant string) error
+	}{
+		{
+			name:           "Valid tenant via HTTP",
+			requestType:    "http",
+			tenant:         "test-tenant",
+			expectedTenant: "test-tenant",
+			expectedError:  false,
+			executeRequest: sendHTTPRequest,
+		},
+		{
+			name:           "Invalid tenant via HTTP",
+			requestType:    "http",
+			tenant:         "invalid-tenant",
+			expectedTenant: "",
+			expectedError:  true,
+			executeRequest: sendHTTPRequest,
+		},
+		{
+			name:           "Valid tenant via gRPC",
+			requestType:    "grpc",
+			tenant:         "test-tenant",
+			expectedTenant: "test-tenant",
+			expectedError:  false,
+			executeRequest: sendGRPCRequest,
+		},
+		{
+			name:           "Invalid tenant via gRPC",
+			requestType:    "grpc",
+			tenant:         "invalid-tenant",
+			expectedTenant: "",
+			expectedError:  true,
+			executeRequest: sendGRPCRequest,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			mockWriter := mocks.NewWriter(t)
+
+			spanProcessor, err := NewSpanProcessor(
+				mockWriter,
+				nil,
+				Options.NumWorkers(1),
+				Options.QueueSize(1),
+				Options.ReportBusy(true),
+			)
+			require.NoError(t, err)
+			defer spanProcessor.Close()
+			logger := zaptest.NewLogger(t)
+
+			portHttp := "4317"
+			portGrpc := "4318"
+
+			var receivedTraces atomic.Pointer[ptrace.Traces]
+			var receivedCtx atomic.Pointer[context.Context]
+			if !tt.expectedError {
+				mockWriter.On("WriteTraces", mock.Anything, mock.Anything).
+					Run(func(args mock.Arguments) {
+						storeContext := args.Get(0).(context.Context)
+						storeTrace := args.Get(1).(ptrace.Traces)
+						receivedTraces.Store(&storeTrace)
+						receivedCtx.Store(&storeContext)
+					}).Return(nil)
+			}
+
+			tenancyMgr := tenancy.NewManager(&tenancy.Options{
+				Enabled: true,
+				Header:  "x-tenant",
+				Tenants: []string{"test-tenant"},
+			})
+
+			rec, err := handler.StartOTLPReceiver(
+				optionsWithPorts(fmt.Sprintf("localhost:%v", portHttp), fmt.Sprintf("localhost:%v", portGrpc)),
+				logger,
+				spanProcessor,
+				tenancyMgr,
+			)
+			require.NoError(t, err)
+			ctx := context.Background()
+			defer rec.Shutdown(ctx)
+
+			var url string
+			if tt.requestType == "http" {
+				url = fmt.Sprintf("http://localhost:%v/v1/traces", portHttp)
+			} else {
+				url = fmt.Sprintf("localhost:%v", portGrpc)
+			}
+			err = tt.executeRequest(ctx, url, tt.tenant)
+			if tt.expectedError {
+				assert.Error(t, err)
+				return
+			}
+			require.NoError(t, err)
+
+			assert.Eventually(t, func() bool {
+				storedTraces := receivedTraces.Load()
+				storedCtx := receivedCtx.Load()
+				if storedTraces == nil || storedCtx == nil {
+					return false
+				}
+				receivedSpan := storedTraces.ResourceSpans().At(0).
+					ScopeSpans().At(0).
+					Spans().At(0)
+				receivedTenant := tenancy.GetTenant(*storedCtx)
+				return receivedSpan.Name() == "test-trace" && receivedTenant == tt.expectedTenant
+			}, 1*time.Second, 100*time.Millisecond)
+
+			mockWriter.AssertExpectations(t)
+		})
+	}
+}
+
+// Helper function to send HTTP request
+func sendHTTPRequest(ctx context.Context, url string, tenant string) error {
+	traceJSON := `{
+		"resourceSpans": [{
+			"scopeSpans": [{
+				"spans": [{
+					"name": "test-trace"
+				}]
+			}]
+		}]
+	}`
+
+	req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, strings.NewReader(traceJSON))
+	if err != nil {
+		return err
+	}
+	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set("x-tenant", tenant)
+
+	resp, err := http.DefaultClient.Do(req)
+	if err != nil {
+		return err
+	}
+	defer resp.Body.Close()
+	if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("unexpected status code: %d", resp.StatusCode)
+	}
+	return nil
+}
+
+// Helper function to send gRPC request
+func sendGRPCRequest(ctx context.Context, url string, tenant string) error {
+	conn, err := grpc.NewClient(
+		url,
+		grpc.WithTransportCredentials(insecure.NewCredentials()),
+	)
+	if err != nil {
+		return err
+	}
+	defer conn.Close()
+
+	md := metadata.New(map[string]string{
+		"x-tenant": tenant,
+	})
+	ctxWithMD := metadata.NewOutgoingContext(ctx, md)
+
+	client := otlptrace.NewTraceServiceClient(conn)
+	req := &otlptrace.ExportTraceServiceRequest{
+		ResourceSpans: []*tracepb.ResourceSpans{
+			{
+				ScopeSpans: []*tracepb.ScopeSpans{
+					{
+						Spans: []*tracepb.Span{
+							{
+								Name: "test-trace",
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+
+	_, err = client.Export(ctxWithMD, req)
+	return err
+}