Change struct to map in order to make dynamic connections (including tests) #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Problem
Setting the credentials dynamically won't work since the
Connection
module by default is a struct (hence, compile time).This also affects the test files of the library, since it relies on explicit connection string. Leaving it blank will throw an error.
To reproduce:
test
env:MIX_ENV=test iex -S mix
ExTypesense.Connection.new
Connection
struct field values returnsnil
.Workaround
Since the problem came from making the connection a struct, it defeats the purpose of making it dynamic (runtime). So we have to change it from struct to map.