Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): ✅ Add options configuration for HTTP client #51

Conversation

shijithkjayan
Copy link
Contributor

  • Added options configuration to config/config.exs for :ex_typesense application.
  • Introduced get_options/0 function in ExTypesense.HttpClient to fetch the options configuration.
  • Updated HTTP request construction in ExTypesense.HttpClient to include options.
  • Added tests for get_options/0 in ExTypesense.HttpClientTest.

This change allows for additional configuration options to be passed to the HTTP client, enhancing its flexibility and configurability.

- Added `options` configuration to `config/config.exs` for `:ex_typesense` application.
- Introduced `get_options/0` function in `ExTypesense.HttpClient` to fetch the `options` configuration.
- Updated HTTP request construction in `ExTypesense.HttpClient` to include `options`.
- Added tests for `get_options/0` in `ExTypesense.HttpClientTest`.

This change allows for additional configuration options to be passed to the HTTP client, enhancing its flexibility and configurability.
@jaeyson jaeyson added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 1, 2024
@jaeyson jaeyson merged commit 23b9ab8 into jaeyson:main Sep 4, 2024
3 checks passed
@jaeyson jaeyson linked an issue Sep 4, 2024 that may be closed by this pull request
@shijithkjayan shijithkjayan deleted the shijith-k/add-configurable-options-for-http-client branch September 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Configurable options for Req.Request in HttpClient
2 participants