Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to Add Japanese translation but... #193

Open
wants to merge 4 commits into
base: feature/localization
Choose a base branch
from

Conversation

Shimo74
Copy link

@Shimo74 Shimo74 commented Aug 22, 2022

It's still not fully translated but I need developer's opinion.

  1. In error.invalid_winners.max, I intentionally did not put {0} in the sentence. I thought it would make for a better translation. But does this cause the bot to make an error? Do I have to add {0} in the sentence?
    (error.invalid_winners.max内で私は意図的に{0}を文章内に入れませんでした。その方が翻訳としてスムーズだと思ったからです。しかし{0}を文章内に加えないとボットがエラーを起こすでしょうか?)
  2. In info.about, when I try to translate All about, I can't get it to translate properly because of the **GiveawayBot** following it. Can you remove the **GiveawayBot** phrase for Japanese translation?(see image) If you remove that sentence, I would translate that sentence info.about = **GiveawayBot**について.
    (info.about 内で、All aboutを翻訳しようとすると、どうしても後ろにある**GiveawayBot**のせいでうまく翻訳できません。日本語翻訳のために**GiveawayBot**を削除してもらうことはできますか?(画像参照)もし削除していただける場合、 info.about = **GiveawayBot**について と翻訳するつもりです)

その他のご指摘、ご意見もお待ちしています。 (I will applicate any other suggestions or comments you may have.)
image

not completed, need help
🔴: 全く合っている気がしない、わからない / Doesn't feel right at all, I can't translate
🟡: より良い翻訳がありそう / There may be a better translation
🔰🎉: 表記ゆれ / Distortion
still not completed but I need devs opinion
@jagrosh
Copy link
Owner

jagrosh commented Aug 22, 2022

Going to do my best to answer your concerns:

  1. The {0} field is filled in with the value that the user provided. This could be included in a separate sentence if it would feel more natural. For example, the current phrase (The number of winners you provided ({0}) was not between 1 and {1}!) could theoretically be replaced by something like: You set the number of winners to {0}. Please set the number of winners to a value between 1 and {1}.
  2. I'll adjust this message to utilize the formatting so that it's All about {0}. You can change your translation to {0}について (the {0} will be replaced with the bolded name of the bot automatically).

fix translation but found another problem
@Shimo74
Copy link
Author

Shimo74 commented Aug 22, 2022

Thank you for quick response! I have changed the sentence to fit to your suggestion.
But I forgot that there is another problem.

In the error.reroll_message_option, does the actual bot translate the name of the app(Reroll Giveaway)? If not translated, I will change that sentence to this:
error.reroll_message_option = Giveawayは以下の方法を使って再抽選することもできます: メッセージを右クリック(PC版) / メッセージを長押し(スマホ版) > **アプリ** > **Reroll Giveaway**
image

@jagrosh
Copy link
Owner

jagrosh commented Aug 22, 2022

"Reroll Giveaway" is the name of the command and will always be in English regardless of your locale. So yes, you should adjust that phrase to include the literal "Reroll Giveaway".

fix translation and it's done!
@Shimo74
Copy link
Author

Shimo74 commented Aug 22, 2022

Fix that sentence, and it's now fully translated! But again, I will applicate any other suggestions or comments you may have. (翻訳についてのご指摘、ご意見をお待ちしています。)

@jagrosh jagrosh changed the base branch from master to feature/localization October 6, 2022 15:09
@jagrosh jagrosh mentioned this pull request Oct 6, 2022
@jagrosh jagrosh changed the base branch from feature/localization-old to feature/localization November 21, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants