-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to Add Japanese translation but... #193
Open
Shimo74
wants to merge
4
commits into
jagrosh:feature/localization
Choose a base branch
from
Shimo74:patch-1
base: feature/localization
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not completed, need help 🔴: 全く合っている気がしない、わからない / Doesn't feel right at all, I can't translate 🟡: より良い翻訳がありそう / There may be a better translation 🔰🎉: 表記ゆれ / Distortion
still not completed but I need devs opinion
Going to do my best to answer your concerns:
|
fix translation but found another problem
"Reroll Giveaway" is the name of the command and will always be in English regardless of your locale. So yes, you should adjust that phrase to include the literal "Reroll Giveaway". |
fix translation and it's done!
Fix that sentence, and it's now fully translated! But again, I will applicate any other suggestions or comments you may have. (翻訳についてのご指摘、ご意見をお待ちしています。) |
Open
jagrosh
changed the base branch from
feature/localization-old
to
feature/localization
November 21, 2023 17:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still not fully translated but I need developer's opinion.
error.invalid_winners.max
, I intentionally did not put {0} in the sentence. I thought it would make for a better translation. But does this cause the bot to make an error? Do I have to add {0} in the sentence?(
error.invalid_winners.max
内で私は意図的に{0}を文章内に入れませんでした。その方が翻訳としてスムーズだと思ったからです。しかし{0}を文章内に加えないとボットがエラーを起こすでしょうか?)info.about
, when I try to translateAll about
, I can't get it to translate properly because of the**GiveawayBot**
following it. Can you remove the**GiveawayBot**
phrase for Japanese translation?(see image) If you remove that sentence, I would translate that sentenceinfo.about = **GiveawayBot**について
.(
info.about
内で、All about
を翻訳しようとすると、どうしても後ろにある**GiveawayBot**
のせいでうまく翻訳できません。日本語翻訳のために**GiveawayBot**
を削除してもらうことはできますか?(画像参照)もし削除していただける場合、info.about = **GiveawayBot**について
と翻訳するつもりです)その他のご指摘、ご意見もお待ちしています。 (I will applicate any other suggestions or comments you may have.)