fix(input): click clear icon to trigger twice (tusen-ai#5511)

jahnli · Jan 23, 2024 · 6da710d · 6da710d
1 parent 8c46915
commit 6da710d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.en-US.md b/CHANGELOG.en-US.md
@@ -76,9 +76,11 @@
 - Fix `n-avatar`'s lazy loading and `fallback-src` prop not working when load error in lazy, closes [#5007](https://github.com/tusen-ai/naive-ui/issues/5007).
 - <del>Fix `n-split` has no color if it's not used in a card.</del>
 - Fix `n-card` `footer-class` prop not working.
+- Fix `n-input` click clear icon to trigger twice when using the `clearable`, closes [#5510](https://github.com/tusen-ai/naive-ui/issues/5510).
 - Fix `n-tabs` may miss over-scroll shadow if `placement` is `'left'` or `'right'`.
 - Fix `n-date-picker` with range type can input start time that is later than end time, closes [#5544](https://github.com/tusen-ai/naive-ui/issues/5544).
 
+
 ### Features
 
 - 🌟 Adds `n-flex` component.

diff --git a/CHANGELOG.zh-CN.md b/CHANGELOG.zh-CN.md
@@ -76,6 +76,7 @@
 - 修复 `n-avatar` 懒加载和懒加载失败时 `fallback-src` 属性都不生效，关闭 [#5007](https://github.com/tusen-ai/naive-ui/issues/5007)
 - <del>修复 `n-split` 不在卡片中使用没有颜色</del>
 - 修复 `n-card` 的 `footer-class` 属性不生效
+- 修复 `n-input` 在使用 `clearable` 时点击触发两次的问题，关闭 [#5510](https://github.com/tusen-ai/naive-ui/issues/5510)
 - 修复 `n-tabs` 在 `placement` 为 `'left'` 和 `'right'` 时初始化滚动阴影可能不正确
 - 修复 `n-date-picker` 在范围类型下，可以通过输入框使开始时间大于结束时间，关闭 [#5544](https://github.com/tusen-ai/naive-ui/issues/5544)
 

diff --git a/src/_internal/clear/src/Clear.tsx b/src/_internal/clear/src/Clear.tsx
@@ -35,7 +35,6 @@ export default defineComponent({
                 <div
                   key="dismiss"
                   class={`${clsPrefix}-base-clear__clear`}
-                  onClick={this.onClear}
                   onMousedown={this.handleMouseDown}
                   data-clear
                 >