Implement Localization. #43
Conversation
|
@andreyjan is attempting to deploy a commit to the FFW Sandbox Team on Vercel. To accomplish this, @andreyjan needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
|
An owner of the FFW Sandbox Team on Vercel accepted @andreyjan's request to join. @andreyjan's commit is now being deployed. |
|
You must have Developer access to commit code to FFW Sandbox on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
There was a problem hiding this comment.
That's a great start!
Can you take a look at my comments and also consider adding a language switcher (dropdown or links, dropdown preferred)
Example from Marketing Starterkit is fine: https://marketing-site.templates.contentful.com/?referrer=contentful
| export default async function LandingPage({ params }: { params: { slug: string[] } }) { | ||
| export default async function LandingPage({ params }: { params: { slug: string[]; locale: string } }) { | ||
| const { locale } = params; | ||
| setStaticParamsLocale(locale); |
There was a problem hiding this comment.
I see setStaticParamsLocale but don't see getStaticParams() in generateStaticParams, isn't the point of setStaticParamsLocale to help generate pages for all locales? Documentation is pretty unclear on that, but maybe looking at source code can help?
There was a problem hiding this comment.
You are correct. I refactored so now we generate pages fro combinations slug + locale.
app/[locale]/layout.tsx
Outdated
| @@ -0,0 +1,13 @@ | |||
| import { ReactElement } from 'react'; | |||
There was a problem hiding this comment.
I'm not convinced a sublayout is a good idea here, shouldn't we wrap the original top level layout with I18nProviderClient as well? I suspect if SiteNavigation or Header would have client components that need translations, those would not work with this setup.
It seems that folks in next-international in general moved all their top level files to [locale]/ folder.
https://github.com/QuiiBz/next-international/blob/main/examples/next-app/app/%5Blocale%5D/layout.tsx
I'm just thinking we should add a client-component example and try to test it, also not a huge fan of moving all files to [locale] subfolder but maybe that's what we might have to do if we see problems with other approaches
There was a problem hiding this comment.
Implemented the structure as in the example and moved the localization provider to the root layout.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No description provided.