Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signature test plugin to jakarta.tck varient #523

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Jun 11, 2024

Fixes #510

  • Swapped signature test plugin from Netbeans -> Jakarta managed version
  • Refactored JDK class ignores to ignore all JDK classes
  • Updated logging for signature testing to aid in debugging
  • Updated system property handling for signature testing to aid in configuration
  • Proof read documentation to verify signature testing documentation matches changes
  • General formatting changes

Local test results:

[6/11/24, 10:51:42:569 CDT] 0000004a k.concurrent.common.signature.ConcurrencySignatureTestRunner I ******************************************************
******************************************************
All package signatures passed.
	Passed packages listed below: 
		jakarta.enterprise.concurrent(static mode)
		jakarta.enterprise.concurrent(reflection mode)
		jakarta.enterprise.concurrent.spi(static mode)
		jakarta.enterprise.concurrent.spi(reflection mode)
	******************************************************
******************************************************

@KyleAure KyleAure self-assigned this Jun 11, 2024
@KyleAure KyleAure requested review from arjantijms and njr-11 June 11, 2024 16:19
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few minor grammar fixes that can optionally be made.

@arjantijms
Copy link
Contributor

Looks good. I do think that the java classes related to the signature test should be moved to a general lib in the TCK project, and not be duplicated (and enhanced) in each project separately. But that's outside the scope of this PR.

@KyleAure KyleAure merged commit 325505e into jakartaee:main Jun 11, 2024
3 checks passed
@KyleAure KyleAure deleted the 510-signature-test-plugin-update branch June 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Switch from org.netbeans.tools to jakarta.tck signature test plugin
3 participants