Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh]update agenda/description/speakers #557

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[zh]update agenda/description/speakers #557

wants to merge 9 commits into from

Conversation

laliwa
Copy link
Contributor

@laliwa laliwa commented Sep 23, 2024

[zh]update agenda/description/speakers

@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for jakartaee-jakartaone ready!

Name Link
🔨 Latest commit ba9a0aa
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-jakartaone/deploys/673c27a274d69500084d66e1
😎 Deploy Preview https://deploy-preview-557--jakartaee-jakartaone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oliviergoulet5 oliviergoulet5 self-requested a review September 24, 2024 14:31
oliviergoulet5
oliviergoulet5 requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@oliviergoulet5 oliviergoulet5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good for the most part. I appreciate the pull request!

I suggest we add a few minor edits to help with SEO. Also, one small edit for some remaining Chinese text on an English language page.

content/2024/chinese/_index.md Outdated Show resolved Hide resolved
content/2024/chinese/program-committee.md Outdated Show resolved Hide resolved
content/2024/chinese/program-committee.zh.md Outdated Show resolved Hide resolved
content/2024/chinese/speakers.md Outdated Show resolved Hide resolved
content/2024/chinese/speakers.zh.md Outdated Show resolved Hide resolved
@oliviergoulet5 oliviergoulet5 mentioned this pull request Oct 3, 2024
Closed
@chrisguindon chrisguindon changed the base branch from master to main October 15, 2024 18:14
@laliwa
Copy link
Contributor Author

laliwa commented Nov 19, 2024

The patch looks good for the most part. I appreciate the pull request!

I suggest we add a few minor edits to help with SEO. Also, one small edit for some remaining Chinese text on an English language page.

Thank you for your suggestions, I think they are all great, and I have made the changes according to what you said.

@oliviergoulet5
Copy link
Member

Awesome @laliwa! Your patch looks good. There is still an unresolved merge conflict. Afterwards, I'll be able to merge your patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviergoulet5 oliviergoulet5 oliviergoulet5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laliwa @oliviergoulet5