Skip to content

Commit

Permalink
Cleanup the platform asciidoc (#1827)
Browse files Browse the repository at this point in the history
Signed-off-by: Scott M Stark <[email protected]>
  • Loading branch information
starksm64 authored Jan 29, 2025
1 parent 4f08d2e commit 577d8db
Show file tree
Hide file tree
Showing 23 changed files with 738 additions and 2,428 deletions.
6 changes: 6 additions & 0 deletions release/src/main/assembly/assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@
<outputDirectory>guides</outputDirectory>
<source>../tcks/apis/persistence/persistence-outside-container/docs/userguide/target/generated-docs/Jakarta-Persistence-TCK-Users-Guide.pdf</source>
</file>

<!-- GlassFish example runners -->
<file>
<outputDirectory>glassfish-runner</outputDirectory>
<source>../glassfish-runner</source>
</file>
</files>

<fileSets>
Expand Down
44 changes: 15 additions & 29 deletions user_guides/platform/src/main/asciidoc/TCKpreface.adoc
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@

[[GBFTI]][[preface]]

Preface
-------
= Preface
:doctype: book

[NOTE]
========================================================================
Expand Down Expand Up @@ -34,45 +31,38 @@ test suite.


[NOTE]
=======================================================================
========
URLs are provided so you can locate resources quickly. However, these
URLs are subject to changes that are beyond the control of the authors
of this guide.
=======================================================================

========

[[GBFUS]][[who-should-use-this-book]]

Who Should Use This Book
~~~~~~~~~~~~~~~~~~~~~~~~
[[who-should-use-this-book]]
= Who Should Use This Book

This guide is for developers of the Jakarta EE {tck_version} technology to assist them
in running the test suite that verifies compatibility of their
implementation of the Jakarta EE {tck_version} Specification.


[[GJFXS]][[before-you-read-this-book]]

Before You Read This Book
~~~~~~~~~~~~~~~~~~~~~~~~~
[[before-you-read-this-book]]
= Before You Read This Book

Before reading this guide, you should familiarize yourself with the Java
programming language, the Jakarta Platform, Enterprise Edition 11 (Jakarta EE
9) Specification, and the JavaTest documentation.
programming language, the Jakarta Platform, Enterprise Edition {tck_version} Specification, and the JavaTest documentation.

The Jakarta Platform, Enterprise Edition 11 (Jakarta EE {tck_version}) Specification can be
The Jakarta Platform, Enterprise Edition {tck_version} Specification can be
downloaded from `https://projects.eclipse.org/projects/ee4j.jakartaee-platform`.

For documentation on the test harness used for running the Jakarta EE {tck_version} Platform TCK
test suite, see
`https://wiki.openjdk.java.net/display/CodeTools/Documentation`.

[[GBFWF]][[typographic-conventions]]

Typographic Conventions
~~~~~~~~~~~~~~~~~~~~~~~
[[typographic-conventions]]
= Typographic Conventions

The following table describes the typographic conventions that are used
in this book.
Expand Down Expand Up @@ -113,14 +103,13 @@ The command to remove a file is `rm` filename.
|=======================================================================


[[FWBSD]][[shell-prompts-in-command-examples]]

Shell Prompts in Command Examples
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[[shell-prompts-in-command-examples]]
= Shell Prompts in Command Examples

The following table shows the default UNIX system prompt and superuser
prompt for the C shell, Bourne shell, and Korn shell.

.Shell Prompts
[width="100%",cols="50%,50%",options="header",]
|=====================================================
|Shell |Prompt
Expand All @@ -131,6 +120,3 @@ prompt for the C shell, Bourne shell, and Korn shell.
|Bash shell |`shell_name-shell_version$`
|Bash shell for superuser |`shell_name-shell_version#`
|=====================================================



70 changes: 70 additions & 0 deletions user_guides/platform/src/main/asciidoc/appeals.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@

[[jakarta-tck-appeals-process]]
== Jakarta TCK Test Appeals Process

Jakarta has a well established process for managing challenges to its
TCKs. Any implementor may submit a challenge to one or more tests in the
Jakarta EE TCK as it relates to their implementation. Implementor
means the entity as a whole in charge of producing the final certified release.
*Challenges filed should represent the consensus of that entity*.

=== Valid Challenges
Any test case (e.g., test class, @Test method), test case configuration (e.g., deployment descriptor), test beans, annotations, and other resources considered part of the TCK may be challenged.

The following scenarios are considered in scope for test challenges:

* Claims that a test assertion conflicts with the specification.
* Claims that a test asserts requirements over and above that of the specification.
* Claims that an assertion of the specification is not sufficiently implementable.
* Claims that a test is not portable or depends on a particular implementation.

=== Invalid Challenges
The following scenarios are considered out of scope for test challenges and will be immediately closed if filed:

* Challenging an implementation’s claim of passing a test. Certification is an honor system and these issues must be raised directly with the implementation.
* Challenging the usefulness of a specification requirement. The challenge process cannot be used to bypass the specification process and raise in question the need or relevance of a specification requirement.
* Claims the TCK is inadequate or missing assertions required by the specification. See the Improvement section, which is outside the scope of test challenges.
* Challenges that do not represent a consensus of the implementing community will be closed until such time that the community does agree or agreement cannot be made. The test challenge process is not the place for implementations to initiate their own internal discussions.
* Challenges to tests that are already excluded for any reason.
* Challenges that an excluded test should not have been excluded and should be re-added should be opened as a new enhancement request

Test challenges must be made in writing via the {TechnologyShortName} specification project issue tracker
as described in <<tck-test-appeals-steps>>

All tests found to be invalid will be placed on the Exclude List
for that version of the {TechnologyShortName} TCK.


[[tck-test-appeals-steps]]
=== TCK Test Appeals Steps

1. Challenges should be filed via the Jakarta EE Platform specification project’s issue tracker using the label `challenge` and include the following information:
* The relevant specification version and section number(s)
* The coordinates of the challenged test(s)
* The exact TCK and exclude list versions
* The implementation being tested, including name and company
* The full test name
* A full description of why the test is invalid and what the correct behavior is believed to be
* Any supporting material; debug logs, test output, test logs, run scripts, etc.

2. Specification project evaluates the challenge. +
Challenges can be resolved by a specification project lead, or a project challenge triage team, after a consensus of the specification project committers is reached or attempts to gain consensus fails.
Specification projects may exercise lazy consensus, voting or any practice that follows the principles of Eclipse Foundation Development Process.
The expected timeframe for a response is two weeks or less.
If consensus cannot be reached by the specification project for a prolonged period of time, the default recommendation is to exclude the tests and address the dispute in a future revision of the specification.

3. Accepted Challenges. +
A consensus that a test produces invalid results will result in the exclusion of that test from certification requirements, and an immediate update and release of an official distribution of the TCK including the new exclude list. The associated `challenge` issue must be closed with an `accepted` label to indicate it has been resolved.

4. Rejected Challenges and Remedy. +
When a`challenge` issue is rejected, it must be closed with a label of `invalid` to indicate it has been rejected.
There appeal process for challenges rejected on technical terms is outlined in Escalation Appeal.
If, however, an implementer feels the TCK challenge process was not followed, an appeal issue should be filed with specification project’s TCK issue tracker using the label `challenge-appeal`.
A project lead should escalate the issue with the Jakarta EE Specification Committee via email ([email protected]).
The committee will evaluate the matter purely in terms of due process.
If the appeal is accepted, the original TCK challenge issue will be reopened and a label of `appealed-challenge` added, along with a discussion of the appeal decision, and the `challenge-appeal` issue with be closed.
If the appeal is rejected, the `challenge-appeal` issue should closed with a label of `invalid`.

5. Escalation Appeal. +
If there is a concern that a TCK process issue has not been resolved satisfactorily, the
https://www.eclipse.org/projects/dev_process/#6_5_Grievance_Handling[Eclipse Development Process Grievance Handling] procedure should be followed to escalate the resolution. Note that this is not a mechanism to attempt to handle implementation specific issues.
5 changes: 5 additions & 0 deletions user_guides/platform/src/main/asciidoc/book.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@
= Jakarta EE Platform, Enterprise Edition {tck_version} Test Compatibility Kit User's Guide, Release 11 for Jakarta EE
:tck_version: 11
:glassfish_version: GlassFish 8.0
:doctype: book
:toc:

:leveloffset: 1

include::title.adoc[]

include::TCKpreface.adoc[]
Expand All @@ -30,6 +33,8 @@ include::building.adoc[]

include::portingpackage.adoc[]

include::appeals.adoc[]

include::commonappdeploy.adoc[]

include::database-config.adoc[]
Expand Down
Loading

0 comments on commit 577d8db

Please sign in to comment.