Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket tck bundle, documentation and signature test. #1237

Merged
merged 1 commit into from
Mar 7, 2024
Merged

websocket tck bundle, documentation and signature test. #1237

merged 1 commit into from
Mar 7, 2024

Conversation

gurunrao
Copy link
Contributor

@gurunrao gurunrao commented Mar 3, 2024

websocket tck bundle, documentation and signature test.

@gurunrao gurunrao merged commit 1f12b78 into jakartaee:tckrefactor Mar 7, 2024
2 checks passed
@scottmarlow
Copy link
Contributor

Thanks @gurunrao!

Fyi, @markt-asf can now be selected as a reviewer for projects that he leads. He now has triage permissions for the Platform TCK as does @lukasj as well.

Any Platform TCK committer can grant the trigage role to others (e.g. likely EE Spec project leads) as well as per https://www.eclipse.org/projects/handbook/#pmi-contributors

@gurunrao gurunrao requested a review from markt-asf March 8, 2024 04:21
@gurunrao
Copy link
Contributor Author

gurunrao commented Mar 8, 2024

Thanks @gurunrao!

Fyi, @markt-asf can now be selected as a reviewer for projects that he leads. He now has triage permissions for the Platform TCK as does @lukasj as well.

Any Platform TCK committer can grant the trigage role to others (e.g. likely EE Spec project leads) as well as per https://www.eclipse.org/projects/handbook/#pmi-contributors

Thanks Scott. Adding trigage role helps. we need review from SPEC committers, who are not committers at Platform TCK . I have added Mark-asf as reviewer for the PR, will implement comments as part of new PR.

@markt-asf - Please feel free to add review comments, will open a new PR for addressing comments.

@gurunrao gurunrao deleted the websocket-bundle branch April 17, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants