-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve usability of JPA TCK #1291
Merged
alwin-joseph
merged 9 commits into
jakartaee:tckrefactor
from
beikov:tckrefactor-jpa-fixes
Apr 30, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
07e968b
Introduce maven profiles to make JPA testing easier
beikov 56bee55
Remove invalid UTF-8 character
beikov b238707
Add README that explains how to run JPA spec tests in IntelliJ
beikov 6dfc9bf
Fix typing issues in some TCK test queries
beikov 8f4d218
Fix a bunch of wrong DDL
beikov 258bf53
Get rid of double quoting SQL identifiers to avoid case sensitive mod…
beikov 24d55ac
Fix sequence schema generation tests to allow for if exists syntax
beikov 1a84ffa
Compare java.sql.Date based on String representation
beikov e4d7c2a
Fix some tests to allow cascade constraints syntax
beikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# JPA spec tests | ||
|
||
## Running in IntelliJ | ||
|
||
Create a run configuration for a test and add the following system properties for e.g. PostgreSQL with Hibernate ORM | ||
|
||
* `-Dplatform.mode=standalone` | ||
* `-Dpersistence.unit.name=JPATCK` | ||
* `-Dpersistence.unit.name.2=JPATCK2` | ||
* `-Djakarta.persistence.jdbc.user=hibernate_orm_test` | ||
* `-Djakarta.persistence.jdbc.password=hibernate_orm_test` | ||
* `-Djdbc.db=postgresql` | ||
* `-Ddb.supports.sequence=true` | ||
* `-Djakarta.persistence.provider=org.hibernate.jpa.HibernatePersistenceProvider` | ||
* `-Djakarta.persistence.jdbc.driver=org.postgresql.Driver` | ||
* `-Djakarta.persistence.jdbc.url=jdbc:postgresql://localhost/hibernate_orm_test?preparedStatementCacheQueries=0&escapeSyntaxCallMode=callIfNoReturn` | ||
* `-Djpa.provider.implementation.specific.properties=hibernate.query.jpaql_strict_compliance=true:hibernate.id.new_generator_mappings=true:hibernate.cache.region.factory_class=org.hibernate.testing.cache.CachingRegionFactory:hibernate.model.generator_name_as_sequence_name=true:hibernate.jpa.compliance.transaction=true:hibernate.jpa.compliance.closed=true:hibernate.jpa.compliance.query=true:hibernate.jpa.compliance.list=true:hibernate.jpa.compliance.caching=true:hibernate.jpa.compliance.global_id_generators=true:hibernate.jpa.compliance=true:hibernate.type.wrapper_array_handling=legacy:hibernate.type.preferred_uuid_jdbc_type=char:hibernate.show_sql=true` | ||
* `-Dpersistence.second.level.caching.supported=true` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm late to review this but this change looks good to me.