JSTL : Update glassfish runner to fix tests #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scottmarlow @gurunrao Post this change only 15 test failures are there with Glassfish8-M5 + JDK21 which are due to the JDK issue caused with space character before AM/PM. |
|
What does the pr accomplish? Is this fixing the asadmin tool by running in a different Maven phase? |
Majorly running the |
gurunrao
approved these changes
May 13, 2024
|
Thanks Alwin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Related PRs:
Pending :
15 test failures with GF8-M5 + JDK21 related to jakartaee/tags#255 due to space character before AM/PM.
com.sun.ts.tests.jstl.compat.onedotzero.JSTLClientIT.positiveFormatLocalizationContextI18NTest
com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextI18NTest
com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextBrowserLocaleTest
com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextBundleTest
com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextLocaleTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDBodyValueTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDDateStyleTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDFallbackLocaleTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDLocalizationContextTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDParseLocaleTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeStyleTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeZoneNullEmptyTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeZonePrecedenceTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeZoneTest
com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTypeTest