Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javaee Module : Fix the refactored tests to run with Glassfish 7.0.10+ #1306

Merged

Conversation

alwin-joseph
Copy link
Contributor

Describe the change
The 24 refactored tests in javaee module was failing with Glassfish 7.0.10+ due to org/slf4j/Logger not found error.
The changes replaced the usage of slf4j logger with System.Logger.

  • The tests pass with 8.0.0-JDK17-M5 + JDK17
  • The tests pass with 8.0.0-M5 + JDK21

Additional context

  • javaee module tests were refactored in Javaee Module Refactoring using Arquillian and JUnit #1205 to use Arquillian/Junit.
  • Currently the javaee tests uses the servlet module of which the tests were migrated to spec project. In case the servlet module is removed from platform-tck project in future changes, the parts of servlet module which is used by other modules should be retained.

@gurunrao
Copy link
Contributor

Describe the change The 24 refactored tests in javaee module was failing with Glassfish 7.0.10+ due to org/slf4j/Logger not found error. The changes replaced the usage of slf4j logger with System.Logger.

* The tests pass with 8.0.0-JDK17-M5 + JDK17

* The tests pass with 8.0.0-M5 + JDK21

Additional context

* javaee module tests were refactored in [Javaee Module Refactoring using Arquillian and JUnit #1205](https://github.com/jakartaee/platform-tck/pull/1205) to use Arquillian/Junit.

* Currently the javaee tests uses the servlet module of which the tests were migrated to spec project. In case the servlet module is removed from platform-tck project in future changes, the parts of servlet module which is used by other modules should be retained.

PR #1200 is open for removal of servlet TCK.
IMO, its good practice to compile using Servlet TCK artifact in classpath, instead of partial retain of the Servlet TCK code within platform TCK repository.

@alwin-joseph alwin-joseph merged commit 0bdf20b into jakartaee:tckrefactor May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants