Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web jpa #1734

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Web jpa #1734

merged 4 commits into from
Jan 9, 2025

Conversation

scottmarlow
Copy link
Contributor

Fixes Issue
Specify the issue (link) that is solved with this pull request.

Related Issue(s)
Specify any related issue(s) links.

Describe the change
A clear and concise description of the change.

Additional context
Add any other context about the problem here.

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow

starksm64 and others added 3 commits December 17, 2024 23:14
Signed-off-by: Scott M Stark <[email protected]>
* trial commit to execute sql statements - issue1716

* update cts-derby-pool creation command

* add java procedures
@arjantijms
Copy link
Contributor

arjantijms commented Jan 8, 2025

Is it not shorter / better for readability to just add SQL commands like "CALL sqlj.remove_jar('APP.dbprocedures', 0);" to the existing ${basedir}/sql/derby/derby.ddl.sql file?

That way it's not needed to add so many tags to the pom.

@scottmarlow scottmarlow marked this pull request as ready for review January 9, 2025 19:45
@scottmarlow
Copy link
Contributor Author

Is it not shorter / better for readability to just add SQL commands like "CALL sqlj.remove_jar('APP.dbprocedures', 0);" to the existing ${basedir}/sql/derby/derby.ddl.sql file?

If that works, I'm not against it but it probably should be done via a separate pull request.

That way it's not needed to add so many tags to the pom.

@scottmarlow scottmarlow merged commit c23d96a into main Jan 9, 2025
3 checks passed
@scottmarlow scottmarlow deleted the web-jpa branch January 9, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants