Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta NoSQL 1.0 #793

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

otaviojava
Copy link
Contributor

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

  • A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
  • Specification PDF in the form of jakarta-wombat-spec-x.y.pdf
  • Specification HTML in the form of jakarta-wombat-spec-x.y.html
  • A specification page named _index.md following the template at:
    https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
  • For a Progress Review, that sufficient progress has been made on a Compatible Implementation and TCK, to ensure that the spec is implementable and testable.
  • For a Release Review, a summary that a Compatible Implementation is complete, passes the TCK, and that the TCK includes sufficient coverage of the specification. The TCK users guide MUST include the instructions to run the compatible implementations used to validate the release.
    Instructions MAY be by reference.
  • The URL of the OSSRH staging repository for the api, javadoc:
  • The URL of the compatibility certification request issue:
    [Certification]: Eclipse JNoSQL nosql#187
  • Specification JavaDoc in the wombat/x.y/apidocs directory.
    If desired, an optional second PR can be created to contain just the JavaDoc in the apidocs directory.

Note: If any item does not apply, check it and mark N/A below it.

@otaviojava otaviojava changed the title Release 1 0 0 Jakarta NoSQL 1.0 Jan 18, 2025
Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit a1eec63
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/678bff81ddbd5600081214b6
😎 Deploy Preview https://deploy-preview-793--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* [Jakarta NoSQL 1.0 Specification Javadoc](./apidocs)
* Maven coordinates
* [jakarta-nosql-api:jakarta.nosql:jar:1.0.0-M1](https://repo1.maven.org/maven2/jakarta/nosql/jakarta.nosql-api/1.0.0-M1/)

* [jakarta-nosql-api:jakarta.nosql:jar:1.0.0](https://repo1.maven.org/maven2/jakarta/nosql/jakarta.nosql-api/1.0.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the displayed

  • groupId be changed to jakarta.nosql (from jakarta-nosql-api)
  • artifactId to jakarta.nosql-api (from jakarta.nosql)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

* [Jakarta NoSQL 1.0 Specification Javadoc](./apidocs)
* Maven coordinates
* [jakarta-nosql-api:jakarta.nosql:jar:1.0.0-M1](https://repo1.maven.org/maven2/jakarta/nosql/jakarta.nosql-api/1.0.0-M1/)

* [jakarta-nosql-api:jakarta.nosql:jar:1.0.0](https://repo1.maven.org/maven2/jakarta/nosql/jakarta.nosql-api/1.0.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect 1.0.0 to be at least staged (if not in Central), but I see only
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be my question: can I release version 1.0.0 even without approval yet?

Comment on lines +49 to +50
* [Jakarta NoSQL 1.0 Specification Document](./nosql-1.0.0.pdf) (PDF)
* [Jakarta NoSQL 1.0 Specification Document](./nosql-1.0.0.html) (HTML)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Jakarta NoSQL 1.0 Specification Document](./nosql-1.0.0.pdf) (PDF)
* [Jakarta NoSQL 1.0 Specification Document](./nosql-1.0.0.html) (HTML)
* [Jakarta NoSQL 1.0 Specification Document](./jakarta-nosql-1.0.0.pdf) (PDF)
* [Jakarta NoSQL 1.0 Specification Document](./jakarta-nosql-1.0.0.html) (HTML)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kazumura
Copy link
Contributor

Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to [email protected].
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

    • The specification project team requests approval by sending an email to the EMO (with cc to the PMC) that contains a link to this PR and a request to the PMC for approval.
  2. Update Jakarta EE API jar

  • Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants